Bug 400589

Summary:	Provide appropriate name for the category "K3btheme" in Discover app store
Product:	[Applications] k3b	Reporter:	Patrick Silva <bugseforuns>
Component:	general	Assignee:	K3b Bugs <k3b-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	michalm, nate, trueg
Priority:	NOR
Version First Reported In:	18.08.1
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://commits.kde.org/k3b/3479acd505867d6963e7a802fcc51cec6e61afe3	Version Fixed/Implemented In:	19.04.0
Sentry Crash Report:

Description Patrick Silva 2018-11-02 12:12:09 UTC

Already reported as bug 400203.

Nate's comment:
"This isn't a discover issue, though. The data comes from KDE programs that install the .knsrc definition files that provide this data. They need to add a "Name" key and provide a pretty name. See this commit for an example:

https://cgit.kde.org/sddm-kcm.git/commit/?id=b3928bb58819c4306a23918762be7cd5aa663979
"

STEPS TO REPRODUCE
1. open discover 
2. click "Applications addons" in the side bar
3. 

OBSERVED RESULT
Name of the category related to K3b (K3btheme) is not user-friendly. See the screenshot.
https://bugsfiles.kde.org/attachment.cgi?id=115852

EXPECTED RESULT
user-friendly name like "K3b Themes".

SOFTWARE VERSIONS
Arch Linux
KDE Plasma Version: 5.14.2
KDE Frameworks Version: 5.51
Qt Version: 5.12 beta3

Comment 1 Nate Graham 2018-12-17 05:22:09 UTC

https://phabricator.kde.org/D17637

Sorry that this utterly trivial change took me a month and a half to submit a patch for!

Comment 2 Nate Graham 2018-12-18 14:11:24 UTC

Git commit 3479acd505867d6963e7a802fcc51cec6e61afe3 by Nate Graham.
Committed on 18/12/2018 at 14:11.
Pushed by ngraham into branch 'master'.

Give KNSRC file a user-friendly name

Summary:
With this change, the catagory name in Discover will be "K3B Themes" instead of "K3Btheme".

See also b3928bb58819c4306a23918762be7cd5aa663979
FIXED-IN: 19.04.0

Reviewers: #kde_applications, apol

Reviewed By: apol

Differential Revision: https://phabricator.kde.org/D17637

M  +1    -0    src/option/k3btheme.knsrc.cmake

https://commits.kde.org/k3b/3479acd505867d6963e7a802fcc51cec6e61afe3

Comment 3 Patrick Silva 2019-02-13 22:56:09 UTC

it's still "K3btheme" in Discover 5.15. :(

Operating System: Arch Linux 
KDE Plasma Version: 5.15.0
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.1

Comment 4 Nate Graham 2019-02-14 03:15:33 UTC

This fix is in K3B version 19.04.0, which hasn't been released yet. We couldn't change it in 18.12.x because the proper fix is a string change, and we don't change strings in the stable version of apps, only in the master branch. I submitted the patch too late to make it into the last release, so we're stuck waiting for the next one.