Bug 400588

Summary: Provide appropriate names for Kmail addons in Discover app store
Product: [Applications] kmail2 Reporter: Patrick Silva <bugseforuns>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: montel
Priority: NOR    
Version: 5.9.2   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Patrick Silva 2018-11-02 12:02:45 UTC 
SUMMARY
Already reported as bug 400203.

Nate's comment:
"This isn't a discover issue, though. The data comes from KDE programs that install the .knsrc definition files that provide this data. They need to add a "Name" key and provide a pretty name. See this commit for an example:

https://cgit.kde.org/sddm-kcm.git/commit/?id=b3928bb58819c4306a23918762be7cd5aa663979
"

STEPS TO REPRODUCE
1. open discover 
2. click "Applications addons" in the side bar
3. 

OBSERVED RESULT
Names of the categories related to Kmail (Accountwizard, ksieve_script, Messageviewer_header_themes) are not user-friendly. See the screenshot.
https://bugsfiles.kde.org/attachment.cgi?id=115852

EXPECTED RESULT
user-friendly names like...
Account Wizard
Ksieve Scripts
Kmail Header Themes

SOFTWARE VERSIONS
Arch Linux
KDE Plasma Version: 5.14.2
KDE Frameworks Version: 5.51
Qt Version: 5.12 beta3
Comment 1 Laurent Montel 2018-11-02 12:34:50 UTC 
Git commit 4dbd8ffc21ee973c9a64d78d833ce4fc48bf7bce by Laurent Montel.
Committed on 02/11/2018 at 12:34.
Pushed by mlaurent into branch 'master'.

Add missing Name

M  +1    -0    src/ksieveui/data/ksieve_script.knsrc

https://commits.kde.org/libksieve/4dbd8ffc21ee973c9a64d78d833ce4fc48bf7bce
Comment 2 Laurent Montel 2018-11-02 12:35:41 UTC 
Git commit 9cb91905d5be79c07279c61d289d35ec28e56ace by Laurent Montel.
Committed on 02/11/2018 at 12:35.
Pushed by mlaurent into branch 'master'.

Add missing Name

M  +1    -0    src/data/kaddressbook_themes.knsrc

https://commits.kde.org/kaddressbook/9cb91905d5be79c07279c61d289d35ec28e56ace
Comment 3 Laurent Montel 2018-11-02 12:36:24 UTC 
Git commit da54d5b7cb17594cae778355a3f2146fed8a2e68 by Laurent Montel.
Committed on 02/11/2018 at 12:35.
Pushed by mlaurent into branch 'master'.

Add missing name

M  +1    -0    src/data/knotes_printing_theme.knsrc

https://commits.kde.org/knotes/da54d5b7cb17594cae778355a3f2146fed8a2e68
Comment 4 Laurent Montel 2018-11-02 12:37:10 UTC 
Git commit b819d96dc0ada167299aac917996790456447243 by Laurent Montel.
Committed on 02/11/2018 at 12:36.
Pushed by mlaurent into branch 'master'.

Add missing Name

M  +1    -0    messageviewer/src/header/data/messageviewer_header_themes.knsrc

https://commits.kde.org/messagelib/b819d96dc0ada167299aac917996790456447243
Comment 5 Laurent Montel 2018-11-02 12:37:58 UTC 
Git commit 2ce608f2caadfdef1ec2e8594d0259147b97b84b by Laurent Montel.
Committed on 02/11/2018 at 12:37.
Pushed by mlaurent into branch 'master'.

Add missing name

M  +1    -0    src/data/korganizer.knsrc

https://commits.kde.org/korganizer/2ce608f2caadfdef1ec2e8594d0259147b97b84b
Comment 6 Laurent Montel 2018-11-02 12:38:48 UTC 
Git commit 4642a0bc8d3950a14f7d7fe0ce7ac51363f37430 by Laurent Montel.
Committed on 02/11/2018 at 12:38.
Pushed by mlaurent into branch 'master'.

Add missing Name

M  +1    -0    src/accountwizard.knsrc

https://commits.kde.org/kmail-account-wizard/4642a0bc8d3950a14f7d7fe0ce7ac51363f37430
Comment 7 Laurent Montel 2018-11-02 12:40:04 UTC 
Seems fixed now
Comment 8 Patrick Silva 2018-11-02 13:09:57 UTC 
Awesome. Thank you Laurent.