| Summary: | s390x: Operand of LOCH treated as unsigned integer | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Andreas Arnez <arnez> |
| Component: | vex | Assignee: | Andreas Arnez <arnez> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jseward |
| Priority: | NOR | ||
| Version First Reported In: | 3.14 SVN | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Sign-extend immediate operand of LOCHI and friends | ||
|
Description
Andreas Arnez
2018-10-30 18:26:32 UTC
Created attachment 115989 [details]
Sign-extend immediate operand of LOCHI and friends
This patch fixes the issue by offering only the non-overlapping vector registers to the register allocator.
(In reply to Andreas Arnez from comment #1) > Created attachment 115989 [details] > Sign-extend immediate operand of LOCHI and friends > > This patch fixes the issue by offering only the non-overlapping vector > registers to the register allocator. Oops, comment to wrong bug. The patch fixes the issue by sign-extending the operand. (In reply to Andreas Arnez from comment #2) > Oops, comment to wrong bug. The patch fixes the issue by sign-extending the > operand. Ah, fabulous stacked casts! I think 3 levels is a new record for this code base. Seems fine. OK to land. (In reply to Julian Seward from comment #3) > Ah, fabulous stacked casts! I think 3 levels is a new record for this > code base. Actually it's done this way in several places in this file already... > Seems fine. OK to land. Thanks, pushed as git commit 9545e9f96. |