Summary: | Display keyboard shortcut for switching Input modes | ||
---|---|---|---|
Product: | [Applications] kate | Reporter: | Tore Havn <veqz> |
Component: | application | Assignee: | Gaurav Pant <geniuspant> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | geniuspant, loh.tar, nate, null, viduuj |
Priority: | NOR | Keywords: | junior-jobs, usability |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | All | ||
Latest Commit: | https://commits.kde.org/ktexteditor/03d1100d8b3497f19d2e609cd948ec836630eb35 | Version Fixed In: | 5.63 |
Description
Tore Havn
2018-10-30 15:54:17 UTC
Yeah, makes sense. I am just getting Started. I think this could be a good place to start with. I was trying to understand the code. I also understand that all the options of the toolbar are added in the kateui.rc file. But I don't know in which part of the code I will add the keyboard shortcut > But I don't know in which part of the code I will add the keyboard shortcut Perhaps it may help when you study these ones https://phabricator.kde.org/D17661 https://phabricator.kde.org/D17609 I am completely new to KDE and found this Junior Job. I'd like to know: Is somebody still working on this? Because if not I'd really like to do it. I have looked into the issue and don't really know how to solve it. Looking at the way the other options are implemented, they either have a selector (like the **Input Mode** Option discussed here) *OR* a checkbox with the Keyboard-Shortcut shown to the right of the options text. None of the "selectable" options have a keyboard shortcut shown in their respective entry. Should I go ahead and make the *Input Mode* Option a toggle option like e.g. *Block Selection Mode*? I'm asking because the source code reads as if the current behavior on *Input Mode* was intentional to the extent that further input modes be added (some day in the future), which would be incompatible with the "toggle" option. Any advice, anyone? Git commit 03d1100d8b3497f19d2e609cd948ec836630eb35 by Dominik Haumann. Committed on 12/09/2019 at 14:24. Pushed by dhaumann into branch 'master'. Add keyboard shortcut for switching Input modes to edit menu M +4 -2 src/view/kateview.cpp https://commits.kde.org/ktexteditor/03d1100d8b3497f19d2e609cd948ec836630eb35 Andreas Hartmann: Sorry, the bug itself was somewhat complicated for a junior job. Simply changing the menus weren't straightforward, but we just managed to fix it now. Hope you find some other worthwhile bugs to fix. :) The bug is fixed by adding the "Switch to next Input Mode" to the submenu as can be seen in this screenshot: https://i.imgur.com/WcX7pvG.png |