Summary: | Add a note stating that identifying with nickserv may result in failures when auto-joining | ||
---|---|---|---|
Product: | [Applications] konversation | Reporter: | Luca Carlon <carlon.luca> |
Component: | general | Assignee: | Konversation Developers <konversation-devel> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | christian.l.christiansen, herzenschein, kde, riku.seppala |
Priority: | NOR | ||
Version: | 1.7.5 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/konversation/74f707e2532d598ee616a9b288a0ee22d43630fb | Version Fixed In: |
Description
Luca Carlon
2018-10-27 11:57:47 UTC
I agree. But in this case, it would make more sense to simply set Plain SASL as default and Nickserv as an option. It's kind of misleading to have a settings group called Auto Identify that doesn't reliably auto-identifies every time. This might lead the user to think they did something wrong or that Konversation is to blame for the auto-login not working as expected. I agree that the default method should not be one that is known to be unreliable. And does it make sense to keep an unreliable method? If it does, should we anyway put a note stating it is unreliable? when "Standard NickServ" is selected and you have set the password, why can't Konversation wait for the "[Notice] -NickServ- You are now identified for..." and only then run auto-join? (In reply to riku.seppala from comment #3) > when "Standard NickServ" is selected and you have set the password, why > can't Konversation wait for the "[Notice] -NickServ- You are now identified > for..." and only then run auto-join? Because that is not standardized and will fail on various networks. Setting SASL as a default is a good idea, since these days most networks support it, but note that not all do. I suspected that. Thanks for explaining. What about my first proposal: adding a simple note explaining the situation to the user, maybe suggesting SASL? It took me hours to understand why that was happening to me and that a solution was one click away :-) How about adding an optional delay for auto-join? Sure it's a hack, but it's an easy feature to add and if it works for 90+% of the users, that's a huge improvement. I was about to file a bug that autojoin doesn't work when I just happened to see this report. I was frustrated by the same issue and was contemplating switching to another IRC client. It was only after I found this bug report that I was able to resolve the issue. I believe either of the amendments suggested by Luca and Timur would be preferable to the status quo. I had to stop using Konversation and switched to X-Chat because Konversataion was causing my Ubuntu desktop to crash. I couldn't open any apps. So at this point, I don't really care any more if this bug is fixed. Perosnally I'd prefer making SASL the default, or if that can't be done for whatever reason, add the note. Adding a delay is a bad workaround which will fail under various circumstances, is highly unreliable and that when there is a working solution (SASL) available on most networks. So I'd oppose that workaround and use a proper solution (default to SASL, add note if can't be done) instead. Git commit 74f707e2532d598ee616a9b288a0ee22d43630fb by Peter Simonsson, on behalf of Christian Christiansen. Committed on 29/03/2020 at 06:45. Pushed by psn into branch 'master'. Changed default auto join from NickServ to SASL. Summary: NickServ often doesn't function well with auto join, so changed default to SASL PLAIN. Included message for NickServ, recommending SASL. Related: bug 397576, bug 382924 Reviewers: #konversation, psn Reviewed By: #konversation, psn Subscribers: psn, #konversation Tags: #konversation Differential Revision: https://phabricator.kde.org/D28329 M +1 -1 src/identity.cpp M +5 -3 src/identitydialog.cpp https://commits.kde.org/konversation/74f707e2532d598ee616a9b288a0ee22d43630fb |