Summary: | Schedule with single frame capture does not initiate meridian flip | ||
---|---|---|---|
Product: | [Applications] kstars | Reporter: | Wolfgang Reissenberger <wreissen> |
Component: | general | Assignee: | Jasem Mutlaq <mutlaqja> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 3.0.1 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Wolfgang Reissenberger
2018-10-24 21:13:53 UTC
The capture module also has no way to know if there "future" captures pending. In its own little world, once all captures are done, we're done. I'm not sure which solution would be fitting for this issue. What about shifting (or adding) this check to preparePreCaptureActions()? Yeah I'd imagine that could work. Can you check it out? Make sure it doesn't cause any regressions? Well, promising that it does not cause any regressions is challenging for the Capture module :-/ But sure, yes, I will give it a try. One possible problem I see is that the capture module might do focusing or dithering and then on the next capture, it decides to do meridian flip. So all the focusing/dithering would be a waste of valuable observing time. So maybe the check should exist in both places. It looks like the Capture module cannot detect the necessity of a meridian flip upfront. The Capture module records the initial hour angle. If the initial hour angle is already west of the meridian, the Capture module assumes that a meridian flip is no longer necessary. This makes sense when the Capture module is used standalone. In combination with the Scheduler, it gets more complicated. The easiest way I see is to set the initial hour angle from outside. But this needs a change in the interface. Does that make sense? Bug fix diff submitted: https://phabricator.kde.org/D17159 Fixed with diff #D17159 (see https://phabricator.kde.org/D17159) |