Bug 400262

Summary: Falkon logo text is unreadable in about dialog when using a dark theme
Product: [Applications] Falkon Reporter: Björn Feber <bfeber>
Component: generalAssignee: David Rosca <nowrep>
Status: RESOLVED FIXED    
Severity: normal CC: anditosan1000, nate, trmdi
Priority: NOR Keywords: usability
Version: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/falkon/3b51982c5dce7fc3c156bcdbde9fe6dfe7320d50 Version Fixed In:
Sentry Crash Report:
Attachments: The unreadable logo text when using a dark theme/color scheme
falkon title graphic dark

Description Björn Feber 2018-10-24 19:34:16 UTC 
SUMMARY
The Falkon logo text in the about dialog is unreadable when you use a dark theme.

STEPS TO REPRODUCE
1. Open the Falkon about dialog

OBSERVED RESULT
The logo text is not readable

EXPECTED RESULT
The logo text should be readable

SOFTWARE VERSIONS
Falkon Version: 3.0.1
Comment 1 Nate Graham 2018-10-24 19:40:31 UTC 
A screenshot would help. :)
Comment 2 Björn Feber 2018-10-25 08:07:41 UTC 
Created attachment 115886 [details]
The unreadable logo text when using a dark theme/color scheme
Comment 3 David Rosca 2018-10-25 08:15:11 UTC 
Well, text here is part of the image. There's not much to do, except place some light background under it.
Comment 4 Björn Feber 2018-10-25 08:17:07 UTC 
Right.
Comment 5 trmdi 2018-10-25 08:19:16 UTC 
(In reply to David Rosca from comment #3)
> Well, text here is part of the image. There's not much to do, except place
> some light background under it.

Create a dark logo and check the window background color to use the right one?
Comment 6 Björn Feber 2018-10-25 08:24:39 UTC 
If the logo is a svg, can you then change the color dynamically (to the light text color from the theme)?
Comment 7 David Rosca 2018-10-25 15:20:06 UTC 
It's not a single color as breeze icons, so that wouldn't work very well.
Comment 8 Andres Betts 2018-10-28 21:41:42 UTC 
Here is a possible replacement
Comment 9 Andres Betts 2018-10-28 21:42:17 UTC 
Created attachment 115955 [details]
falkon title graphic dark
Comment 10 Christoph Cullmann 2018-12-11 20:01:59 UTC 
Git commit 3b51982c5dce7fc3c156bcdbde9fe6dfe7320d50 by Christoph Cullmann, on behalf of Björn Feber.
Committed on 11/12/2018 at 20:02.
Pushed by cullmann into branch 'master'.

Fix unreadable Falkon logo text when using a dark theme

Summary:
https://bugs.kde.org/show_bug.cgi?id=400262

This puts a light rounded rectangle behind the logo, so the logo text is readable when using a dark theme.
{F6451049}

Test Plan: Open the about window (Application Menu -> About Falkon).

Reviewers: #falkon, drosca

Reviewed By: #falkon, drosca

Subscribers: drosca, falkon, #falkon

Tags: #falkon

Differential Revision: https://phabricator.kde.org/D17307

M  +286  -65   src/lib/data/icons/other/about.svg

https://commits.kde.org/falkon/3b51982c5dce7fc3c156bcdbde9fe6dfe7320d50