Bug 400256

Summary: Make Gradient Editors Work Consistently
Product: [Applications] krita Reporter: Kenneth Evans <ken>
Component: UsabilityAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: griffinvalley, halla, scottpetrovic, tamtamy.tymona
Priority: NOR    
Version First Reported In: 4.1.5   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Kenneth Evans 2018-10-24 16:33:47 UTC
SUMMARY
I cannot remove stops in the gradient editor.  According to the documentation, you right click to remove them.  Either right or left clicking gives a cursor that closes.  I have tried double clicking, dragging them to the ends, and other things.  I have found no way to remove them (except by going to the file and editing the SVG).  I am using stop gradients.  I have not checked segmented gradients.

STEPS TO REPRODUCE
1. Add a stop
2. Right click to remove it
3. 

OBSERVED RESULT
Doesn't get removed.

EXPECTED RESULT
Gets removed.

SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Kenneth Evans 2018-10-24 16:42:18 UTC
Meant to say either way gives a hand cursor that closes.
Comment 2 Scott Petrovic 2018-10-24 16:51:51 UTC
have you just tried to drag it all the way to the left or right? I am not sure exactly all the shortcuts that should remove stop gradients, but dragging it all the way to the sides seem to remove it for me.
Comment 3 Gremriel 2018-10-24 16:58:38 UTC
I can't remove the stops as per the manual either, but you can drag the stop you want to delete all the way to the right or left (off the gradient). The stop will be removed, and the initial color of the starting and ending stops is not altered.
Comment 4 Kenneth Evans 2018-10-24 20:04:01 UTC
As stated, I tried that.  They just piled up at the end.  In some cases it looked like they were gone, but they were just on top of each other.  I spent a fair amount of time trying, including several restarts.  If there is a trick to it, I didn't find it.
Comment 5 Halla Rempt 2018-10-30 13:56:20 UTC
Note that we have two gradient editors, that work in differently. The Stop Gradient Editor and the Segment Gradient Editor. The Segment Gradient Editor allows you to remove stops with right-click and remove segment, the Stop Gradient Editor by dragging the stops out of the gradient.

The Stop Gradient Editor should be fixed to implement right-click delete.
Comment 6 Kenneth Evans 2018-12-11 04:01:02 UTC
I just tried using the segmented gradient editor.  It did not seem to work well at all.  On clicking a stop, it usually did not change the colors to be edited.  I was trying to create a grayscale gradient with five values, and it was very frustrating.  I would make a change and something weird would happen, apparently because I was not editing the stop I had clicked.  The stop doesn't seem to get highlighted either.  I could move the stops, but not make the colors change reliably, and often not at all.  I ended up figuring out the file format and created the gradient in a text editor.  (I wanted 5 bars of increasing gray values to get values from an image using a Gradient Map.)

That worked, to some extent at least.  The Gradient icon in the tool bar showed my gradient correctly (5 bars of increasing gray values).  However, the gradient editor itself showed a continuous grayscale, not blocks, and attempting to use it as a Filter Mask with Gradient Map also had a continuous grayscale.

BTW the document ion does not say to right click the bar to split the gradient.  Took a while to figure that out.

[After spending all that time, I WAS able to get what I wanted with a Stop (SVG) gradient without having to do it in an editor.]

I'm not doing well with gradients. ;-)
Comment 7 Kenneth Evans 2018-12-11 04:51:32 UTC
More problems.  I edit a stop gradient.  It changes in the Gradients panel, but it isn't saved.
Comment 8 Kenneth Evans 2018-12-11 04:58:29 UTC
I even tried renaming it, and it didn't save it (nor modify ko_gradients.blacklist).
Comment 9 Kenneth Evans 2018-12-11 17:30:27 UTC
I looked at this again this morning.  I am still confused as to what is happening.  Perhaps there is no way to save your edits.  In the best of all possible worlds the edit dialog would have Save and Cancel.

It would be nice to be able to see the XML, too.

The documentation is not helpful as to what this dialog does.

The only thing that is working for me is to edit the gradients elsewhere and manually put them in the gradients directory in the settings -- not what you call user friendly ;-)
Comment 10 Tiar 2021-03-17 15:22:13 UTC
This sounds like a wish, not a bug, and a wish that requires some design work first.
Even that "just implement delete on right click in one of the editor" doesn't seem suitable anymore because both editors now have context menus for right-click.
For any progress in this wish, it should follow this instruction: https://docs.krita.org/en/untranslatable_pages/new_features.html and preferably has some suggestions for design.
Comment 11 wolthera 2021-06-09 08:30:52 UTC
resolved in 5.0