Summary: | No notification (or automatic reload) when file changed on disk | ||
---|---|---|---|
Product: | [Applications] kile | Reporter: | André Nichterlein <andre.nichterlein> |
Component: | editor | Assignee: | Michel Ludwig <michel.ludwig> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | RBredereck |
Priority: | NOR | ||
Version: | 2.9.92 | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/okular/dcacd830f47f7e942e4c57712bd00a8a93306e3a | Version Fixed In: |
Description
André Nichterlein
2018-10-23 10:38:20 UTC
Git commit dcacd830f47f7e942e4c57712bd00a8a93306e3a by Michel Ludwig. Committed on 28/10/2018 at 16:35. Pushed by mludwig into branch 'master'. Don't call 'KDirWatch::stopScan()' KDirWatch maintains one global watch list per application only. Calling 'stopScan' could therefore affect other code paths that make use of KDirWatch (other loaded KParts, for example). M +11 -5 part.cpp https://commits.kde.org/okular/dcacd830f47f7e942e4c57712bd00a8a93306e3a To make use of this fix right away, you will have to compile & install Okular's master branch. Thanks Michel for the fix. First tests indicate that it solves the problem. I've created a backport of the upstream patch for the current okular version in ubuntu lts (18.04): https://launchpad.net/~rbredereck/+archive/ubuntu/okular-patched-for-kile3 If the problem is really solved, I will annoy the ubuntu maintainers to include it as well. Git commit 2ea44c5291d80300f711fc5adaac833b2297d3d8 by Michel Ludwig. Committed on 01/11/2018 at 06:48. Pushed by mludwig into branch 'master'. Fix KDirWatch problem description in Part::setWatchFileModeEnabled The problem is actually not the global watch list in KDirWatch, but KDirWatch::stopScan causes unintended side effects via KDirWatchPrivate::_isStopped. This bug is tracked in bug report 400541. M +2 -3 part.cpp https://commits.kde.org/okular/2ea44c5291d80300f711fc5adaac833b2297d3d8 |