Bug 399983

Summary:	Progress notification is not persistent
Product:	[Applications] kdeconnect	Reporter:	Erik Duisters <e.duisters1>
Component:	android-application	Assignee:	Erik Duisters <e.duisters1>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Android
OS:	All
Latest Commit:	https://commits.kde.org/kdeconnect-android/6992f2f5ee5bc0a1be0b8f109a33472a2eeec0fc	Version Fixed/Implemented In:
Sentry Crash Report:

Description Erik Duisters 2018-10-18 13:16:38 UTC

SUMMARY

When sending a file from android the progress notification can be dismissed while the file is still being transmitted

STEPS TO REPRODUCE
1. Send a big file from android
2. Open the notification drawer and swiped the progress notification away

OBSERVED RESULT

The notification can be dismissed

EXPECTED RESULT

The notification should not be dismissible until the transmission has either finished or failed.

SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 5.51.0
Qt Version: 5.11.1

ADDITIONAL INFORMATION

Comment 1 Nicolas Fella 2018-11-06 18:57:20 UTC

Git commit 6992f2f5ee5bc0a1be0b8f109a33472a2eeec0fc by Nicolas Fella, on behalf of Erik Duisters.
Committed on 06/11/2018 at 18:57.
Pushed by nicolasfella into branch 'master'.

While uploading a file the notification should not be dismissable

Summary: BUG: 399983

Test Plan:
Send a big file from Android
The notification can not be dismissed while the file is being transferred

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16713

M  +1    -0    src/org/kde/kdeconnect/Plugins/SharePlugin/NotificationUpdateCallback.java

https://commits.kde.org/kdeconnect-android/6992f2f5ee5bc0a1be0b8f109a33472a2eeec0fc