Summary: | libatomic breaks compilation in MacOS | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | amyspark <amy> |
Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | halla |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | macOS | ||
Latest Commit: | Version Fixed In: |
Description
amyspark
2018-10-18 00:58:45 UTC
Please note that, according to CMake, the proper flag in x64 for detecting atomic support is HAVE_CXX_ATOMICS64_WITHOUT_LIB . I've asked the author of that patch to take a look, and I'll revert the patch for now: https://phabricator.kde.org/D16184 Git commit dbe8be703a18aa858b4739d0b0537f60cac1c629 by Boudewijn Rempt. Committed on 20/10/2018 at 09:35. Pushed by rempt into branch 'master'. Do not link to libatomic on macOS M +4 -2 libs/image/CMakeLists.txt https://commits.kde.org/krita/dbe8be703a18aa858b4739d0b0537f60cac1c629 I've reverted the patch completely, since it didn't work on freebsd either. Let's see whether the original author can come up with a better patch :-) |