| Summary: | PlasmaComponents Button: different button & icon size between PC2 with iconSource and PC3 with icon.name | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] libplasma | Reporter: | Nate Graham <nate> |
| Component: | components | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, kde |
| Priority: | NOR | ||
| Version First Reported In: | 5.51.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-framework/f9736191161b29d77742778f5ad109ae43e12e2b | Version Fixed/Implemented In: | 5.62 |
| Sentry Crash Report: | |||
| Attachments: | Button and icon sizes: PC3 vs PC2 | ||
> import org.kde.plasma.components 3.0 as PC2
Sigh, should of course be `import org.kde.plasma.components 2.0 as PC2`
I found the same thing on my machine, Plasma Components 3 doesn't set a size on the icon and so it just takes whatever the SVG's native size is. Git commit f9736191161b29d77742778f5ad109ae43e12e2b by Camilo Higuita.
Committed on 22/08/2019 at 22:28.
Pushed by camiloh into branch 'master'.
make button icons follow a reasonable size and layout
Summary:
with the Plasma style buttons which have an icon look wrong. The icon size is too big and in consecuence the whole button is drawn way too big.
With this patch the icon is set to a standard size and drawn in the button layout, in a way it looks consistent with other button with no icons.
example:
Before path:
{F7270612}
{F7270611}
With patch:
{F7270610}
{F7270609}
FIXED-IN: 5.62
Reviewers: #plasma, mart, ngraham
Reviewed By: ngraham
Subscribers: ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23352
M +14 -6 src/declarativeimports/plasmacomponents3/Button.qml
https://commits.kde.org/plasma-framework/f9736191161b29d77742778f5ad109ae43e12e2b
|
Created attachment 115716 [details] Button and icon sizes: PC3 vs PC2 Consider the following two pieces of code in a Widget: import org.kde.plasma.components 3.0 as PC2 PC2.Button { iconSource: "configure" text: i18nc("@action:button", "Configure...") onClicked: { plasmoid.action("configure").trigger(); } } import org.kde.plasma.components 3.0 as PC3 PC3.Button { icon.name: "configure" text: i18nc("@action:button", "Configure...") onClicked: { plasmoid.action("configure").trigger(); } } The PC2 version produces a reasonably-sized button with a reasonably-sized icon in it. The PC3 version will produce a larger button with a larger icon. See attached screenshot. For a concrete example, see the weather and comic widgets.