| Summary: | Fails to build with QT5.7.1 | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Simon <freisim93> |
| Component: | Portability-Compilation | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version First Reported In: | 6.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/1ee755a2f03aae73ed52cb3e43450989871d54f8 | Version Fixed/Implemented In: | 6.0.0 |
| Sentry Crash Report: | |||
yes fine Simon, no problem Gilles Caulier Git commit 1ee755a2f03aae73ed52cb3e43450989871d54f8 by Simon Frei. Committed on 17/10/2018 at 12:30. Pushed by sfrei into branch 'master'. update FIXED-IN: 6.0.0 M +2 -1 NEWS https://commits.kde.org/digikam/1ee755a2f03aae73ed52cb3e43450989871d54f8 |
I just tried to compile digikam master and while it works fine on QT5.11.1, it fails on QT5.7.1 (that's just what is provided on debian testing/stable respectively). digikam/core/utilities/searchwindow/searchtabheader.cpp: In member function ‘virtual void Digikam::KeywordLineEdit::contextMenuEvent(QContextMenuEvent*)’: digikam/core/utilities/searchwindow/searchtabheader.cpp:119:21: error: invalid use of incomplete type ‘class QContextMenuEvent’ menu->exec(e->globalPos()); ^~ In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QWidget:1:0, from digikam/core/utilities/searchwindow/searchtabheader.h:29, from digikam/core/utilities/searchwindow/searchtabheader.cpp:24: /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:80:7: note: forward declaration of ‘class QContextMenuEvent’ class QContextMenuEvent; ^~~~~~~~~~~~~~~~~ Digikam depends on >=5.6.0 (https://www.digikam.org/api/index.html#externaldeps). I understand that's really old, but the fix is trivial, so why not have it: --- a/core/utilities/searchwindow/searchtabheader.cpp +++ b/core/utilities/searchwindow/searchtabheader.cpp @@ -39,6 +39,7 @@ #include <QInputDialog> #include <QIcon> #include <QMenu> +#include <QContextMenuEvent> // KDE includes Any objections?