Bug 399911

Summary:	Blacklisted effects still available from UI
Product:	[Applications] kdenlive	Reporter:	Clint Moyer <contact>
Component:	User Interface	Assignee:	Clint Moyer <contact>
Status:	RESOLVED MOVED
Severity:	normal	CC:	fritzibaby
Priority:	NOR	Keywords:	junior-jobs
Version:	18.08.2
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:

Description Clint Moyer 2018-10-17 04:15:49 UTC

SUMMARY
My understanding was effects on the blacklist were not supposed to be available through the UI. Please correct me if I am wrong in that assumption. At the very least this file seems to be a source of confusion.

https://cgit.kde.org/kdenlive.git/tree/data/blacklisted_effects.txt?h=v18.08.2

STEPS TO REPRODUCE
1. Open latest version of application
2. View effects menu

OBSERVED RESULT
Many of the blacklisted elements are present in the UI. We should either update the blacklist or fix this. For example "Sharpen" is from the blacklisted "frei0r.sharpness" effect but we can see it here.

https://cgit.kde.org/kdenlive.git/tree/data/effects/frei0r_sharpness.xml?h=v18.08.2

EXPECTED RESULT
Blacklisted elements should not be present in the UI.

SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Clint Moyer 2018-10-17 05:01:43 UTC

I provided a code change:

https://phabricator.kde.org/D16268

This should be reviewed for the intended effect. Namely, how valid is the current blacklist.