Bug 399822

Summary: Option to exclude fullscreen windows from 'dim inactive' desktop effect
Product: [Plasma] kwin Reporter: adamska156
Component: effects-variousAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: 5.14.0   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://commits.kde.org/kwin/597445e2a677ce0dccfb5c4b583cf7ecb2326472 Version Fixed/Implemented In: 5.15.0
Sentry Crash Report:

Description adamska156 2018-10-15 05:37:21 UTC 
FEATURE REQUEST
Dim Inactive should have an option and possibly by default exclude dimming fullscreen windows.

STEPS TO REPRODUCE (WHAT HAPPENS INSTEAD)
1. Fullscreen a video playing on youtube or something on one monitor
2. Open another app on second monitor

OBSERVED RESULT
The fullscreen window will dim meaning you can't easily watch something on one monitor and continue using the other.

EXPECTED RESULT
Fullscreen app shouldn't dim under any circumstance.

SOFTWARE VERSIONS
KDE Plasma Version: 5.14
KDE Frameworks Version: 5.50.0
Qt Version: 5.11.2
Comment 1 adamska156 2018-10-15 05:58:48 UTC 
The best workaround I've found for this in the mean time is to click the 'keep above' window button before fullscreening the window. Then the window will be excluded as long as you don't have the 'keep above windows' option ticked in the 'dim inactive' settings. However this still isn't ideal.
Comment 2 Vlad Zahorodnii 2018-10-15 07:39:14 UTC 
Git commit 597445e2a677ce0dccfb5c4b583cf7ecb2326472 by Vlad Zagorodniy.
Committed on 15/10/2018 at 07:39.
Pushed by vladz into branch 'master'.

[effects/diminactive] Add option to exclude fullscreen windows from dimming

Summary:
Such an option would be useful for people that are used to watch videos
in the fullscreen mode.

By default, we still dim fullscreen windows because watching videos in
fullscreen mode is not the only one use-case. One could have a text
editor in fullscreen mode on one screen and Konsole on another screen.
In that case, it would be desired to dim the text editor if the latter
is active. Also, because we don't have stats of how the fullscreen mode
is used by KDE Plasma users.
FIXED-IN: 5.15.0

Test Plan:
* Unchecked the "Fullscreen windows" checkbox;
* Opened Konsole;
* Opened Firefox in the fullscreen mode;
* Pressed Alt+Tab;
* (Firefox stayed bright)

Reviewers: #kwin, #plasma, davidedmundson

Reviewed By: #kwin, #plasma, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16216

M  +5    -0    effects/diminactive/diminactive.cpp
M  +8    -0    effects/diminactive/diminactive.h
M  +3    -0    effects/diminactive/diminactive.kcfg
M  +7    -0    effects/diminactive/diminactive_config.ui

https://commits.kde.org/kwin/597445e2a677ce0dccfb5c4b583cf7ecb2326472