Bug 399805

Summary:	KDiagram fails to compile on MacOS on CI
Product:	[Unmaintained] Craft	Reporter:	wojnilowicz <lukasz.wojnilowicz>
Component:	Blueprints	Assignee:	Hannah von Reth <vonreth>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bcooksley, windows-bugs-null
Priority:	NOR
Version First Reported In:	master
Target Milestone:	---
Platform:	unspecified
OS:	macOS
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	KGantt linking failure

Description wojnilowicz 2018-10-14 17:22:21 UTC

Created attachment 115642 [details]
KGantt linking failure

1) KDiagram fails to compile on MacOS on CI and that can be seen here
https://binary-factory.kde.org/view/MacOS/job/KMyMoney_Release_macos/47/consoleText

2) It doesn't fail on my local MacOS.

3) Configuration part of this package on CI is as follows:

-- The C compiler identification is AppleClang 8.0.0.8000038
-- The CXX compiler identification is AppleClang 8.0.0.8000038
-- Check for working C compiler: /usr/bin/clang
-- Check for working C compiler: /usr/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/clang++
-- Check for working CXX compiler: /usr/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - not found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Performing Test HAVE_DATE_TIME
-- Performing Test HAVE_DATE_TIME - Success
-- Could not set up the appstream test. appstreamcli is missing.
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Failed
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Failed
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success

4) Configuration part of this package on my local MacOS is as follows:

-- The C compiler identification is AppleClang 9.1.0.9020039
-- The CXX compiler identification is AppleClang 9.1.0.9020039
-- Check for working C compiler: /usr/bin/clang
-- Check for working C compiler: /usr/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/clang++
-- Check for working CXX compiler: /usr/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - not found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Performing Test HAVE_DATE_TIME
-- Performing Test HAVE_DATE_TIME - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success

5) I suspect it fails because of following lines
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Failed
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Failed

Comment 1 Hannah von Reth 2018-10-15 06:28:06 UTC

The cmake required version needs to be raised to 3

Comment 2 wojnilowicz 2018-10-16 16:37:02 UTC

(In reply to Hannah von Reth from comment #1)
> The cmake required version needs to be raised to 3

Why?

Comment 3 Hannah von Reth 2018-10-16 19:23:57 UTC

To detect Apple Clang vs LLVM Clang cmake 3 is required.

Comment 4 Ben Cooksley 2018-10-17 09:31:39 UTC

This would be the issue for https://binary-factory.kde.org/job/KAlgebra_Nightly_macos/209/console as well I suspect.

Comment 5 wojnilowicz 2018-10-21 07:43:50 UTC

@Hannah
Thank you for the tip.

@Ben
I've set a patch for KAlgebra.