Bug 399760

Summary: Spectacle window is not focused on PrScrn global hotkey
Product: [Applications] Spectacle Reporter: Alexander Potashev <aspotashev>
Component: GeneralAssignee: Boudhayan Gupta <me>
Status: RESOLVED FIXED    
Severity: wishlist CC: bugseforuns, fabrizio.ruggeri, nate
Priority: NOR    
Version: 18.04.2   
Target Milestone: ---   
Platform: Other   
OS: Linux   
URL: https://phabricator.kde.org/T9855
Latest Commit: https://commits.kde.org/spectacle/4b52871a674ac5c48919b0ef902db063f9afbd66 Version Fixed In: 19.04.0
Sentry Crash Report:

Description Alexander Potashev 2018-10-13 15:43:16 UTC 
SUMMARY
Spectacle window is not focused on PrScrn global hotkey.

STEPS TO REPRODUCE
1. Start Spectacle (e.g. by hitting PrintScreen)
2. Focus another application's window.
3. Press PrintScreen key.

OBSERVED RESULT
Nothing happens.

EXPECTED RESULT
The Spectacle window should be brought to the front and focused.

SOFTWARE VERSIONS
KDE Frameworks 5.48.0,
Qt 5.11.1 (собрана с версией 5.11.1),
Оконная система xcb.

ADDITIONAL INFORMATION
Version 18.04.3
Comment 1 Nate Graham 2019-02-14 21:57:10 UTC 
*** Bug 404283 has been marked as a duplicate of this bug. ***
Comment 2 Nate Graham 2019-02-22 21:17:24 UTC 
Git commit 4b52871a674ac5c48919b0ef902db063f9afbd66 by Nate Graham, on behalf of David Redondo.
Committed on 22/02/2019 at 21:17.
Pushed by ngraham into branch 'master'.

[WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running

Summary:
Adds options to configure what happens if the Print key is pressed while Spectacle is already running as discussed in T9855.
Taking a new screenshot and opening a new Instance are working. If already two Instances are open only one new one will be created.
Focusing the window doesn't work it only gets marked in the panel.
Also when in a second instance the option is changed it doesn't affect the other instances altough the spectaclerc is changed.
I also need some help with the strings as currently the description is very long and not good but I couldn't think of anything suitable:
{F6623755}

Closes T9855
Related: bug 383897, bug 374770
FIXED-IN: 19.04.0

Reviewers: #spectacle, #vdg, davidedmundson, ngraham

Reviewed By: #spectacle, #vdg, ngraham

Subscribers: davidedmundson, zzag, abetts, ngraham, #spectacle

Tags: #spectacle

Maniphest Tasks: T9855

Differential Revision: https://phabricator.kde.org/D19153

M  +23   -0    src/Gui/SettingsDialog/GeneralOptionsPage.cpp
M  +2    -0    src/Gui/SettingsDialog/GeneralOptionsPage.h
M  +20   -0    src/SpectacleConfig.cpp
M  +10   -1    src/SpectacleConfig.h
M  +16   -0    src/SpectacleCore.cpp

https://commits.kde.org/spectacle/4b52871a674ac5c48919b0ef902db063f9afbd66