| Summary: | Erase drawings in presentation mode should use a different icon than eraser | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | Simone Gaiarin <simgunz> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | Keywords: | junior-jobs, usability |
| Version: | 1.5.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/okular/1547c7834029ab784fc2cd25d6291459d868687c | Version Fixed In: | 19.04.0 |
| Sentry Crash Report: | |||
| Attachments: | Duplicated icon eraser | ||
"draw-eraser-delete" is a red trash bin as the icon "delete", so maybe also the icon "delete" is fine. Git commit 1547c7834029ab784fc2cd25d6291459d868687c by Oliver Sander, on behalf of Simone Gaiarin. Committed on 21/12/2018 at 11:44. Pushed by sander into branch 'master'. Move "erase drawings" action to last position and change its icon It is more logical to have the drawing tools first, then the eraser, and then the action to delete everything. Also the two actions to erase things are close to each other now. The icon of "erase drawing" has been changed to draw-eraser-delete-objects to distinguish it from the "Eraser" tool. Differential Revision: https://phabricator.kde.org/D16171 M +1 -1 part.cpp M +6 -5 ui/presentationwidget.cpp https://commits.kde.org/okular/1547c7834029ab784fc2cd25d6291459d868687c |
Created attachment 115606 [details] Duplicated icon eraser SUMMARY "Erase drawing" in presentation mode could use the icon "draw-eraser-delete" instead of using the same icon as "Eraser" (which is "draw-eraser"). See attachment STEPS TO REPRODUCE 1. Open presentation mode 2. Show the top bar OBSERVED RESULT Two tools have the same eraser icon EXPECTED RESULT The two tools should have different icons SOFTWARE VERSIONS (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION