| Summary: | Kdevelop crashed when closing | ||
|---|---|---|---|
| Product: | [Applications] kdevelop | Reporter: | Adrien Cordonnier <adrien.cordonnier> |
| Component: | general | Assignee: | kdevelop-bugs-null |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | igorkuo |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kdevelop/kdevelop/commit/147add2ed8b3eac24b6bbd1af818f4685ab2aced | Version Fixed In: | 5.6.1 |
|
Description
Adrien Cordonnier
2018-10-08 11:37:41 UTC
A possibly relevant merge request was started @ https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/167 This crash can be reproduced reliably with the following steps: 1. Execute-Launch an application from KDevelop. 2. Repeat the 1st step with the same application while the previous instance is still running. 3. In the "Job Already Running" dialog that appears after the 2nd step click the Cancel button. 4. (optional) Exit the still running first application instance. 5. Exit KDevelop. Git commit 147add2ed8b3eac24b6bbd1af818f4685ab2aced by Igor Kushnir. Committed on 22/09/2020 at 11:55. Pushed by igorkushnir into branch '5.6'. Don't crash after Cancel in Job Already Running dialog When a user Execute-Launches an application a second time while the previously launched instance of this application is still running, the "Job Already Running" dialog appears with 3 buttons. If a user clicks the Cancel button, a NativeAppJob kills itself Quietly. This NativeAppJob belongs to an ExecuteCompositeJob, which is not notified when a subjob is killed Quietly. So the ExecuteCompositeJob keeps waiting for it to finish. When this waiting ExecuteCompositeJob is killed (e.g. via "Stop All" button or on KDevelop exit), it attempts to kill the subjob it believes is still running, but which in fact is long since destroyed. This usually causes a segmentation fault. Aleix Pol fixed a similar crash when the "Kill All Instances" button in the "Job Already Running" dialog is clicked in 8430d3058f92725b4e6b7d85d8d68550ce12ee79. Related: bug 416874 FIXED-IN: 5.6.1 M +1 -1 plugins/execute/nativeappjob.cpp https://invent.kde.org/kdevelop/kdevelop/commit/147add2ed8b3eac24b6bbd1af818f4685ab2aced |