| Summary: | Dolphin: Places: Regression: Move items up/down not working properly | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | foss |
| Component: | panels: places | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, frodekolgrov, kde, kde, lcswillems, mail, nate, nortexoid, parker.l.reed, renatooliveira.cin, rgb.ide, rockonthemoonfm, wakutiteo.bi |
| Priority: | NOR | Keywords: | usability |
| Version: | 18.08.1 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/dolphin/303cd17444e1fb88d1f92a911f7c770214b8f90e | Version Fixed In: | 19.04.0 |
| Attachments: |
configuration file for Dolphin
configuration file for Dolphin parker reed comment re work around configuration file search 01 configuration search 02 configuration search 03 dolphin handbook: configuration christoph feck comment an attempt to move a directory up |
||
|
Description
foss
2018-10-06 03:56:14 UTC
Have a similar issue. Cant move a specific folder above trash. Whenever I try, the items remain in the same position. Confirmed, if somebody who runs Dolphin 17.12.3 could test this that'd be great. Found a workaround: open any KDE file dialog (I used Ctrl O in Chrome) and sort the entries there. I've intermittently seen this with 18.08 and git master, but I've never been able to come up with a reproducible test case. *** Bug 399722 has been marked as a duplicate of this bug. *** Reporter of bug 399722: reordering works if "Show all entries" is checked! *** Bug 400172 has been marked as a duplicate of this bug. *** *** Bug 395269 has been marked as a duplicate of this bug. *** (In reply to Nate Graham from comment #4) > I've intermittently seen this with 18.08 and git master, but I've never been > able to come up with a reproducible test case. The bug happens when you have any entry hidden and it's above or between the entries that you want to reorder. But if the hidden entry is below the icons that you want to reorder, it works. And always works if 'Show All Entries' is checked. I confirm the bug. usability suffers here. But nice to read about the workround at least. Would be nice if it could be fixed. *** Bug 402980 has been marked as a duplicate of this bug. *** Yes, can confirm this. Workaround works. I had the Desktop entry hidden... Created attachment 117360 [details]
configuration file for Dolphin
Created attachment 117361 [details]
configuration file for Dolphin
Created attachment 117362 [details]
parker reed comment re work around
I had already tried to find the configuration file, but as the snapshots show I can not find it
Created attachment 117363 [details]
configuration file search 01
Created attachment 117364 [details]
configuration search 02
Created attachment 117365 [details]
configuration search 03
Created attachment 117366 [details]
dolphin handbook: configuration
Created attachment 117367 [details]
christoph feck comment
I was unable to locate
Created attachment 117368 [details]
an attempt to move a directory up
It really seems that you have a hidden entry between your "from" and "to" destination. Right-click on an empty area of the places panel, and I bet you get an option "Show hidden places" or "Show all entries". When you get the "move, copy, link" options, you have dropped an entry above another. You have to place it between two entries so the blue border line appears. Hope this help. (In reply to lurulf from comment #22) > It really seems that you have a hidden entry between your "from" and "to" > destination. Right-click on an empty area of the places panel, and I bet you > get an option "Show hidden places" or "Show all entries". When you get the > "move, copy, link" options, you have dropped an entry above another. You > have to place it between two entries so the blue border line appears. Hope > this help. That might help, yes, but doesn't solve the problem that it used to work without workaround and now it doesn't. Git commit 303cd17444e1fb88d1f92a911f7c770214b8f90e by Nate Graham, on behalf of Tigran Gabrielyan. Committed on 20/03/2019 at 16:46. Pushed by ngraham into branch 'Applications/19.04'. Fix rearranging items in places panel with hidden items Summary: `m_sourceModel->movePlace` is called using index from the view model. This becomes an issue when there are hidden places items. This change calls `m_sourceModel->movePlace` using the corresponding mapped source index. FIXED-IN: 19.04.0 Test Plan: # Create at least 4 Places items # Hide first item # Drag the now first visible item between second and third item Actual: The item does not move Expected: The first visible item should now be second visible item in the list Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19901 M +4 -1 src/panels/places/placesitemmodel.cpp https://commits.kde.org/dolphin/303cd17444e1fb88d1f92a911f7c770214b8f90e |