Bug 399395

Summary:	Use the saved file instead of tmp one after it has been saved for exporting
Product:	[Applications] Spectacle	Reporter:	trmdi
Component:	General	Assignee:	Boudhayan Gupta <me>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns, mihael.vercek, nate, pierre, proteus5
Priority:	NOR	Keywords:	junior-jobs, usability
Version First Reported In:	18.08.1
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/spectacle/e5fd391d2416afa14fd2c53ffdd58dddb04dc53c	Version Fixed/Implemented In:	18.12.0
Sentry Crash Report:

Description trmdi 2018-10-05 05:07:05 UTC

SUMMARY
Use the saved file instead of tmp one after it has been saved

STEPS TO REPRODUCE
1. Take a screenshot
2. Click Save
3. Export the saved image to Gwenview, Gimp...

OBSERVED RESULT
Gwenview, Gimp... opens the file in /tmp/Spectacle...

EXPECTED RESULT
Gwenview, Gimp... opens the saved file in ~/Pictures/...

SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2018-10-05 20:36:19 UTC

Yeah, this has tripped me up as well. Essentially, when the user chooses "Export > [app or 'other application...']", spectacle should save the file to the default save location instead of to the /tmp directory. It should continue to use the /tmp directory for other Export operations.

Comment 2 Nate Graham 2018-10-13 20:41:45 UTC

*** Bug 399747 has been marked as a duplicate of this bug. ***

Comment 3 Nate Graham 2018-10-19 13:26:34 UTC

Git commit e5fd391d2416afa14fd2c53ffdd58dddb04dc53c by Nate Graham.
Committed on 19/10/2018 at 13:26.
Pushed by ngraham into branch 'master'.

Don't save to a temp file if exporting to another app

Summary:
When exporting a screenshot to a local app for further processing, the image is saved to `/tmp/`, which causes issues in the other app, not least of which is that the file is not writable, so {nav Save} operations fail.

This patch makes Spectacle save the file to the default location when exporting to another app.
FIXED-IN: 18.12.0

Test Plan:
1. {nav Export > [some app or Other Application...]}
2. Observe that the screenshot is saved at the default location, and then opened in the app of your choice
3. Edit the image in that app and do {nav File > Save}
4. Observe that it works!

Reviewers: #spectacle, #kde_applications, broulik, utecht, alexeymin, shubham

Reviewed By: #spectacle, alexeymin

Subscribers: pino

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D16191

M  +6    -2    src/Gui/ExportMenu.cpp

https://commits.kde.org/spectacle/e5fd391d2416afa14fd2c53ffdd58dddb04dc53c

Comment 4 trmdi 2018-10-19 13:54:40 UTC

If before exporting, you manually saved the file, or save as... to /some/where/else/ will it get the saved file correctly?

Comment 5 Nate Graham 2018-10-20 05:08:24 UTC

*** Bug 395172 has been marked as a duplicate of this bug. ***

Comment 6 Nate Graham 2018-10-20 14:10:01 UTC

*** Bug 396632 has been marked as a duplicate of this bug. ***