Bug 399370

Summary:	offline update state stability
Product:	[Applications] Discover	Reporter:	Harald Sitter <sitter>
Component:	PackageKit	Assignee:	Aleix Pol <aleixpol>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, rdieter
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/discover/26ac7c780fd749d10a149f578649c5dda2e05e5a	Version Fixed/Implemented In:
Sentry Crash Report:

Description Harald Sitter 2018-10-04 10:30:19 UTC

After doing an offline update the update plasmoid still thinks updates are available and offers to update again.

The update page as well as the updater plasmoid should change into a 'restart-required' state telling the user to reboot, and ideally offering a button to poke ksmserver to start the reboot.

Discover can aslo easily cause the update to get "unstaged" by calling pk refresh, so I expect most, if not all, update functionality should be covered with a fairly global check for 'if updates are staged' and return early if that is the case.

Comment 1 Aleix Pol 2018-10-20 00:05:13 UTC

Git commit 26ac7c780fd749d10a149f578649c5dda2e05e5a by Aleix Pol.
Committed on 20/10/2018 at 00:02.
Pushed by apol into branch 'master'.

pk: don't offer offline updates after they've been downloaded

Insist on rebooting instead

M  +6    -0    discover/qml/UpdatesPage.qml
M  +5    -0    libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp
M  +12   -0    libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp
M  +10   -0    libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp
M  +14   -0    libdiscover/resources/AbstractBackendUpdater.cpp
M  +13   -0    libdiscover/resources/AbstractBackendUpdater.h
M  +10   -0    libdiscover/resources/ResourcesUpdatesModel.cpp
M  +3    -0    libdiscover/resources/ResourcesUpdatesModel.h

https://commits.kde.org/discover/26ac7c780fd749d10a149f578649c5dda2e05e5a