Bug 399301

Summary:	Use inlined frames in Massif XTree output.
Product:	[Developer tools] valgrind	Reporter:	Nick Nethercote <n.nethercote>
Component:	general	Assignee:	Julian Seward <jseward>
Status:	RESOLVED FIXED
Severity:	normal	CC:	philippe.waroquiers
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Bug Depends on:
Bug Blocks:	399355
Attachments:	Use inlined frames in Massif XTree output

Description Nick Nethercote 2018-10-02 08:00:34 UTC

Created attachment 115360 [details]
Use inlined frames in Massif XTree output

DHAT can show inlined frames, but Massif currently can't. The attached patch fixes this. I have tested that it works on the Rust compiler, which was my motivating example: see https://github.com/rust-lang/rust/issues/52028#issuecomment-402409368, especially the part "Massif doesn't get great stack traces due to inlining, but DHAT does a better job by using debuginfo."

Comment 1 Philippe Waroquiers 2018-10-07 15:22:23 UTC

Thanks for the patch, which after a quick reading looks ok to me.
I will take a more in depth look at it.
(wondering if it would not be interesting to also do that
for the xtree kcachegrind output format, and also the
output as produced by callgrind).

Philippe

Comment 2 Nick Nethercote 2018-10-23 07:57:00 UTC

Any reason not to land this? I think it's ready. It's a simple change and a clear improvement.

Comment 3 Philippe Waroquiers 2018-10-23 19:31:13 UTC

(In reply to Nick Nethercote from comment #2)
> Any reason not to land this? I think it's ready. It's a simple change and a
> clear improvement.

Sorry, I intended to take a look at it, but had no time.
I will take a look this week-end, and so patch should be pushed very soon now.

Comment 4 Philippe Waroquiers 2018-10-27 18:32:38 UTC

Patch (with some little modifications) pushed as 66b5a4e9c 

Thanks for the patch

Philippe