Summary: | The highlights for the two trailing spaces in markdown documents unrecoverably disappear after changing an related option | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-ktexteditor | Reporter: | KLsz |
Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | a.samirh78, KLsz |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/ktexteditor/8fb410574b142207d88353ed712a5bd08440d08f | Version Fixed In: | 5.57 |
Description
KLsz
2018-10-01 13:27:19 UTC
Git commit 8fb410574b142207d88353ed712a5bd08440d08f by Christoph Cullmann, on behalf of Ahmad Samir. Committed on 24/02/2019 at 17:06. Pushed by cullmann into branch 'master'. Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline Summary: QTextFormat::FontUnderline has been deprecated upstream for a long time. It seems that for some time setting the underline attribute for syntax highlighting has been broken, i.e. a user can't set it via the config widget and setKateExtendedAttributeList always sets it to false. The latter meant that when the user applied any changes that would write katesyntaxhighlightingrc, the underline attribute for syntax HL would unconditionally be set to false which leads to some weird situations, (e.g. bug 399278 where un/setting "highlight trailing spaces" causes katesyntaxhighlightingrc to get written to disk which leads to Markdown:linebreak losing its underline attribute for good). FIXED-IN: 5.57 Reviewers: #ktexteditor, cullmann, dhaumann Reviewed By: #ktexteditor, cullmann Subscribers: kde-frameworks-devel, kwrite-devel Tags: #kate, #frameworks Differential Revision: https://phabricator.kde.org/D19161 M +2 -2 src/schema/katestyletreewidget.cpp M +1 -1 src/syntax/katehighlight.cpp M +1 -1 src/syntax/katesyntaxmanager.cpp https://commits.kde.org/ktexteditor/8fb410574b142207d88353ed712a5bd08440d08f |