Bug 399185

Summary:	No ability to moving within with arrow keys
Product:	[Plasma] plasmashell	Reporter:	jiiy
Component:	Desktop icons & Folder View widget	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	major	CC:	nate, plasma-bugs
Priority:	NOR
Version:	5.13.5
Target Milestone:	1.0
Platform:	Neon
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-desktop/13ff4a319309b05fe50d4fd8da7878c1e0fe0d66	Version Fixed In:	5.12.8
Sentry Crash Report:

Description jiiy 2018-09-28 14:33:24 UTC

SUMMARY
I added FolderView to panel, setted shortcut for it and when I activate FolderView via shortcut I can not move around with arrow keys. Tab key is only moving to pin button and not further.
Also just found out that when you invoke it with a mouse you can move just for 1st level (i.e. Downloads,Documents) but can not go back with back button on the top (can do it with left arrow key)

STEPS TO REPRODUCE
1. set shortcut for FolderView
2. invoke it with shortcut
3. 

OBSERVED RESULT
cannot move around with arrow keys

EXPECTED RESULT
working arrow keys

SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 5.13.5
KDE Frameworks Version: 5.50
Qt Version: 5.11.1

ADDITIONAL INFORMATION

Comment 1 Eike Hein 2018-09-28 16:16:08 UTC

Reproduced.

This is a regression.

Will try to fix soonish.

Comment 2 Eike Hein 2018-10-04 11:10:14 UTC

Git commit 94eb9f9e5321eaab9fd75e946cd83efb79e10dd0 by Eike Hein.
Committed on 04/10/2018 at 11:09.
Pushed by hein into branch 'master'.

Fix initial focus

Summary:
Now arrow key nav works when opening a panel applet via keyboard
shortcut

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15856

M  +1    -1    containments/desktop/package/contents/ui/FolderViewLayer.qml

https://commits.kde.org/plasma-desktop/94eb9f9e5321eaab9fd75e946cd83efb79e10dd0

Comment 3 Nate Graham 2018-10-04 17:41:52 UTC

Could we get this into the stable branch too?

Comment 4 Eike Hein 2018-10-04 18:29:15 UTC

Git commit 13ff4a319309b05fe50d4fd8da7878c1e0fe0d66 by Eike Hein.
Committed on 04/10/2018 at 18:27.
Pushed by hein into branch 'Plasma/5.12'.

Fix initial focus

Summary:
Now arrow key nav works when opening a panel applet via keyboard
shortcut

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15856

M  +1    -1    containments/desktop/package/contents/ui/FolderViewLayer.qml

https://commits.kde.org/plasma-desktop/13ff4a319309b05fe50d4fd8da7878c1e0fe0d66

Comment 5 Eike Hein 2018-10-04 18:41:40 UTC

I put it into 5.12, but I need Kai to do the merge-up into 5.14 and master tomorrow due to some unrelated conflicts.

Comment 6 Nate Graham 2018-10-04 18:42:37 UTC

Awesome, thanks!