Bug 399170

Summary:	All resource selection widgets share zoom settings (and do that inconsistently)
Product:	[Applications] krita	Reporter:	Ahab Greybeard <ahab.greybeard>
Component:	Dockers	Assignee:	Krita Bugs <krita-bugs-null>
Status:	CONFIRMED ---
Severity:	minor	CC:	dimula73, halla
Priority:	NOR
Version:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Debian stable
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Ahab Greybeard 2018-09-28 08:17:55 UTC

The Patterns docker swatch sizes can be adjusted by Ctrl+Scroll in the swatch area, as noted in the manual.

However, the Brush Presets docker icon size adjustment slider also affects the Patterns docker swatch sizes (at the same time as it changes the Brush Presets docker icon sizes).

This has been observed in the latest nightly builds of 4.2.0 pre-alpha for Linux and Windows and seems to have been the case since 4.0.3(?) first introduced the Brush Presets docker icon size slider.

This is a minor UI/cosmetic matter but it affects the User Experience.

Comment 1 Halla Rempt 2018-10-08 08:50:15 UTC

Hm, with the new palette docker, the size cannot be changed anymore. So technically, this bug isn't relevant anymore. I'll rename it.

Comment 2 Dmitry Kazakov 2019-05-01 10:04:14 UTC

Palette docker is not supposed to change the size of the swatches. The user creates a palette of a fixed number of columns and rows and the widget is not supposed to relayout them. All the colors should be placed as the user has added them.

Though the original problem is still actual. All resource selection widgets in Krita share the same thumbnail size.

Steps to reproduce:

Problem 1:
1) Open Brush Presets docker, notice the thumbnail size
2) Open Brush Editor, select "Predefined Brush" tab, Ctrl+wheel over it to change the zoom.
3) See that the Presets docker also changes the size.

Problem 2:
...
2) Open Prush Presets drop-down, try to move 'Icon Size' slider
3) The zoom of the brushes in drop-down and in the docker changes inconsistently

I think we should fix this bug in either of the two ways:

A) Make every single resource view have its own zoom
B) Make all resource views share the zoom, but share it consistently.

Comment 3 Halla Rempt 2020-07-02 11:08:53 UTC

Note: this is already true in 4.3, where changing the size of the icons in the preset docker changes the size of the icons in the patterns docker (though not vice verse)

Comment 4 Halla Rempt 2020-10-27 13:18:54 UTC

Note 2: we actually have code explicitly for synchronizing the size of the resource choosers: KisResourceItemChooserSync. This is enabled for the pattern chooser, the gamut mask chooser, the brush chooser and the preset chooser.

So, at some point, someone decided that this was correct... See for instance https://bugs.kde.org/show_bug.cgi?id=333169 and this commit:

https://bugs.kde.org/show_bug.cgi?id=333169