Bug 399121

Summary:	inconsistent display of avatar
Product:	[Applications] systemsettings	Reporter:	Tristan Kobusch <tristan.kobusch>
Component:	kcm_users	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	minor	CC:	bugseforuns, djwolf400, nate, thothonegan
Priority:	NOR	Keywords:	junior-jobs
Version:	5.16.4
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed In:	5.20
Sentry Crash Report:

Description Tristan Kobusch 2018-09-26 21:50:17 UTC

SUMMARY
The way the user avatar is displayed in the User Manager and User Switcher Applet is inconsistent with the lockscreen

STEPS TO REPRODUCE
trivial

OBSERVED RESULT
the avatar has a rectangular shape

EXPECTED RESULT
It should be displayed in a circle

SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 5.13.90
KDE Frameworks Version: 5.50.0
Qt Version: 5.11.2

ADDITIONAL INFORMATION
I think the new way the lock screen handles this should be prefered.

Comment 1 Nate Graham 2018-09-27 22:45:49 UTC

That's true, it should!

Code is here: https://cgit.kde.org/user-manager.git/tree/src/lib/accountmodel.cpp#n145

Shouldn't be too tough for a new contributor who has some familiarity with C++ or Qt.

Comment 2 djwolf 2018-09-29 03:14:39 UTC

Would it be possible for me to pick this up?

Comment 3 Nate Graham 2018-09-29 04:17:17 UTC

Absolutely! Let me know if you need a hand. Our documentation is at:
- https://community.kde.org/Get_Involved/development
- https://community.kde.org/Infrastructure/Phabricator

Comment 4 djwolf 2018-09-29 04:26:40 UTC

(In reply to Nate Graham from comment #3)
> Absolutely! Let me know if you need a hand. Our documentation is at:
> - https://community.kde.org/Get_Involved/development
> - https://community.kde.org/Infrastructure/Phabricator

Trying to setup an environment with QtCreator. I hit a segmentation fault when trying to run the compiled version of user-manager.

Comment 5 Nate Graham 2018-09-29 04:31:20 UTC

Sounds like there's an issue with compiled version. :)

I can't offer development support in a bug tracker, so please check out the #kde-devel channel on Freenode IRC. Folks there can help you get up and running!

Comment 6 djwolf 2018-09-29 04:48:34 UTC

(In reply to Nate Graham from comment #5)
> Sounds like there's an issue with compiled version. :)
> 
> I can't offer development support in a bug tracker, so please check out the
> #kde-devel channel on Freenode IRC. Folks there can help you get up and
> running!

See this every time I try to post anything there: "#kde-devel :Cannot send to nick/channel"

Comment 7 Nate Graham 2020-05-21 23:25:41 UTC

This is fixed in the Plasma 5.20 rewrite. Now at long last, all of the avatars are inside circles!