Bug 399116

Summary:	Enter shouldn't close the Configure Krita window, especially on Shortcuts tab
Product:	[Applications] krita	Reporter:	Tiar <tamtamy.tymona>
Component:	Usability	Assignee:	vanyossi <ghevan>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla, wkg28406
Priority:	NOR
Version:	4.1.1
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://commits.kde.org/krita/9480babff23b5a991dcca63313cd3b2e510380fe	Version Fixed In:
Sentry Crash Report:

Description Tiar 2018-09-26 20:46:16 UTC

SUMMARY
On Keyboard Shortcuts tab in Main Menu -> Settings -> Configure Krita people usually search for shortcuts. Search bar works without clicking "Enter", but in other programs confirming the search phrase is actually required, so some people can click "Enter" at the end of the search phrase to confirm (because they have a habit to do so). As a result the whole window closes, which is frustrating. It shouldn't work that way, users can even not know what happened and why.


STEPS TO REPRODUCE
1. Open Settings -> Configure Krita.
2. Click "Keyboard Shortcuts" tab.
3. Write "ctrl" in search bar (optional).
4. Click Enter.

OBSERVED RESULT
Configure Krita dialog closes.

EXPECTED RESULT
Configure Krita dialog doesn't close, the search result is shown.

Comment 1 wkg28406 2018-09-26 21:40:06 UTC

krita-4.2.0-pre-alpha-04a7ade-x86_64.appimage

confirming, have found this rather frustrating in the past as well

Comment 2 vanyossi 2018-10-10 14:57:43 UTC

Git commit a59e8de8137c36741cff32c2e1d2bd3655d0641e by Ivan Yossi.
Committed on 10/10/2018 at 14:57.
Pushed by ivany into branch 'master'.

Enter shouldn't close the Configure Krita window

M  +10   -1    libs/ui/dialogs/kis_dlg_preferences.cc
M  +2    -1    libs/ui/dialogs/kis_dlg_preferences.h

https://commits.kde.org/krita/a59e8de8137c36741cff32c2e1d2bd3655d0641e

Comment 3 Halla Rempt 2018-10-11 08:27:26 UTC

Git commit 9480babff23b5a991dcca63313cd3b2e510380fe by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 11/10/2018 at 07:53.
Pushed by rempt into branch 'krita/4.1'.

Enter shouldn't close the Configure Krita window

(cherry picked from commit a59e8de8137c36741cff32c2e1d2bd3655d0641e)

M  +10   -1    libs/ui/dialogs/kis_dlg_preferences.cc
M  +2    -1    libs/ui/dialogs/kis_dlg_preferences.h

https://commits.kde.org/krita/9480babff23b5a991dcca63313cd3b2e510380fe