| Summary: | The window decorations configuration pop-up needs a Defaults icon | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Andrew Crouthamel <andrew.crouthamel> |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bfeber, bugseforuns, kde, nate |
| Priority: | NOR | Keywords: | junior-jobs |
| Version First Reported In: | 5.13.5 | ||
| Target Milestone: | --- | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/frameworkintegration/50593c5618998535cc9f482aa25565c5aeb368ce | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Andrew Crouthamel
2018-09-23 03:50:53 UTC
Another note. The defaults icon currently used in the main window is not the same one used elsewhere. May be best to standardize on the other one. Confirmed.
It uses QDialogButtonBox correctly, yet the icon for defaults isn't being applied there. Even inside QtDesigner.
QDialogButtonBox doesn't set icons for:
case QDialogButtonBox::YesToAll:
case QDialogButtonBox::NoToAll:
case QDialogButtonBox::SaveAll:
case QDialogButtonBox::Abort:
case QDialogButtonBox::Retry:
case QDialogButtonBox::Ignore:
case QDialogButtonBox::RestoreDefaults:
Doing so means changing QDialogButtonBox then QStyle to add an SP_DialogDefaults enum and then changing kstyle :/
(or I do a shoddy lazy kwin oneliner)
I'll fix properly in Qt. In the meantime, it can be a nice junior job for someone's first patch. kcmwin/kwindecoration/declarative-plugin/previewbridge.cpp ~line 213 get the restore defaults button, set an icon explicitly. Ideally using KStandardGuiItem to get the icon name. *** Bug 404813 has been marked as a duplicate of this bug. *** I forgot to push my patch: https://codereview.qt-project.org/254494 Should we still do the workaround or just close this? Is your patch included in Qt 5.13 beta2 David? This bug persists here. Operating System: Arch Linux KDE Plasma Version: 5.15.4 KDE Frameworks Version: 5.57.0 Qt Version: 5.13.0 beta2 Made a patch: https://phabricator.kde.org/D20709 >Is your patch included in Qt 5.13 beta2 David?
Yes, but we need the matching breeze side to set the icon. That's not merged as it's hard to merge a frameworks patch against non-released code in case it changes later.
Looks like the enum is only in Qt 5.14: https://github.com/qt/qtbase/blob/9a9bdebb92eda34939c8a7442f06d24ded82b799/src/widgets/styles/qstyle.cpp#L2116 (In reply to Björn Feber from comment #10) > Looks like the enum is only in Qt 5.14: > https://github.com/qt/qtbase/blob/9a9bdebb92eda34939c8a7442f06d24ded82b799/ > src/widgets/styles/qstyle.cpp#L2116 I can make a patch that sets it for Qt 5.14 or higher though if you want. (In reply to Björn Feber from comment #11) > I can make a patch that sets it for Qt 5.14 or higher though if you want. Here it is: https://phabricator.kde.org/D24415 Git commit 50593c5618998535cc9f482aa25565c5aeb368ce by Björn Feber. Committed on 08/10/2019 at 14:19. Pushed by bfeber into branch 'master'. Add standard icons to support to all entries in QDialogButtonBox Summary: Implement the new enumarations introduced in Qt 5.14: https://codereview.qt-project.org/c/qt/qtbase/+/254494/ Test Plan: Can't really test since Qt 5.14 is not released yet, but QDialogButtonBox buttons should now all have icons. Reviewers: #frameworks, #vdg, davidedmundson, ngraham Reviewed By: #vdg, davidedmundson, ngraham Subscribers: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24415 M +17 -1 src/kstyle/kstyle.cpp https://commits.kde.org/frameworkintegration/50593c5618998535cc9f482aa25565c5aeb368ce I can confirm that this bug is fixed on Plasma 5.18 beta + Qt 5.14. :) Thank you all. Operating System: Arch Linux KDE Plasma Version: 5.17.90 KDE Frameworks Version: 5.66.0 Qt Version: 5.14.0 |