| Summary: | Invert filter outputs wrong results on 16 bits/integer images | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Alex <eneeen> |
| Component: | Filters | Assignee: | vanyossi <ghevan> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/krita/4d7268e9ad2dd51234ecb055032fb722443f393b | Version Fixed In: | |
| Attachments: | Invert filter test on gradient | ||
Git commit 6f05272d1bfc7e9c42e400038a6725d62d566c53 by Ivan Yossi. Committed on 16/10/2018 at 17:38. Pushed by ivany into branch 'master'. Summary: Fixes Invert filter for all but CMYK and LAB 32bit float It seems the values are not normalized on inversion step. Reviewers: #krita Tags: #krita Differential Revision: https://phabricator.kde.org/D16207 M +1 -2 libs/pigment/KoColorSpaceAbstract.h M +139 -6 libs/pigment/KoInvertColorTransformation.h M +0 -32 plugins/color/lcms2engine/colorspaces/rgb_u8/RgbU8ColorSpace.cpp M +0 -2 plugins/color/lcms2engine/colorspaces/rgb_u8/RgbU8ColorSpace.h https://commits.kde.org/krita/6f05272d1bfc7e9c42e400038a6725d62d566c53 Git commit 4d7268e9ad2dd51234ecb055032fb722443f393b by Boudewijn Rempt, on behalf of Ivan Yossi. Committed on 20/11/2018 at 08:23. Pushed by rempt into branch 'krita/4.1'. Summary: Fixes Invert filter for all but CMYK and LAB 32bit float It seems the values are not normalized on inversion step. Reviewers: #krita Tags: #krita Differential Revision: https://phabricator.kde.org/D16207 M +1 -2 libs/pigment/KoColorSpaceAbstract.h M +139 -6 libs/pigment/KoInvertColorTransformation.h M +0 -32 plugins/color/lcms2engine/colorspaces/rgb_u8/RgbU8ColorSpace.cpp M +0 -2 plugins/color/lcms2engine/colorspaces/rgb_u8/RgbU8ColorSpace.h https://commits.kde.org/krita/4d7268e9ad2dd51234ecb055032fb722443f393b |
Created attachment 115142 [details] Invert filter test on gradient git: b94785f windows It seems invert filter is not working as expected. Take a look at kra file: left is original image, middle is invert done with color adjustments (correct, matches PS invert and invert from levels), right is invert filter.