Bug 398912

Summary:	Can't select locked layer using select mode shortcut
Product:	[Applications] krita	Reporter:	katearcher89
Component:	Layer Stack	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	normal	CC:	halla, wkg28406
Priority:	NOR
Version First Reported In:	4.1.1
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description katearcher89 2018-09-21 11:47:05 UTC

Trying to select a locked layer with R shortcut(a select mode in canvas input settings) results in selecting the layer underneath it.

How to replicate:
1. Create three layers.
2. Draw something on each of them.
3. lock the middle one.
4. Press R and try to select the middle one.
5. The bottom one will be selected instead of the one that actually contains the pixels you have selected.

Expected result: The middle one should be selected. 

Why is it a problem? Because when having alot of layers and groups you want to lock some of them so you won't mess with them by accident. But sometimes you want to know what layer is seen at the specific spot of the image and maybe tweak/change that layer. But with being unable to select the layer you have to go through manually looking through all of the locked layers to find the culprit and that can be pretty tedious and really needlessly complicated.

Comment 1 wkg28406 2018-09-21 22:32:51 UTC

krita-4.2.0-pre-alpha-127857b-x86_64.appimage

confirming

It selects the next active layer beneath the one that is locked, not the layer directly below in the layer stack, but physically below where you are clicking.

This seems somewhat intentional as a locked layer basically acts as "pass through" since it shouldn't be able to be modified.

Comment 2 Halla Rempt 2018-10-07 14:37:12 UTC

This is actually the way the R select layer option is designed -- it's avoid accidentally selecting locked layers an painting on them.

Comment 3 katearcher89 2018-10-08 00:56:05 UTC

(In reply to Boudewijn Rempt from comment #2)
> This is actually the way the R select layer option is designed -- it's avoid
> accidentally selecting locked layers an painting on them.

But that's inconsistent and greatly devalue the usefulness of R select layer option -- since instead of just selecting the layer I still have to manually look through the layer stack. If the user don't know that it is intended(and the chances of that are HUGE) he'll decide it's a bug and stop using the instrument all together(That's actually my case and a few other users of krita at my work).

And I don't even understand how can you paint on a locked layer immediately after selecting it with 'R' -- it's locked, you should get a warning, since R is for _selecting_, not painting. And that reasoning is kinda confusing and mixing two different scenarios into one, actually. 

Because in case of _selecting_ you are only choosing the layer whatever the purpose is, and when you are _painting_, you have already chosen the layer that you will paint on with a full understanding of the layer properties. Trying to cut some corners and save half a second in one place(immediately painting) actually increase tenfold the time that is spent in the other place(selecting and organizing layers).