Bug 398878

Summary: krdc crashes when disconnecting from VNC servers
Product: [Applications] krdc Reporter: Luke-Jr <luke-jr+kdebugs>
Component: VNCAssignee: Urs Wolfer <uwolfer>
Status: RESOLVED FIXED    
Severity: major CC: tildearrow
Priority: NOR    
Version: 18.04   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: backtrace

Description Luke-Jr 2018-09-20 16:18:50 UTC
Created attachment 115124 [details]
backtrace

Application: krdc (18.04.3)

Qt Version: 5.11.1
Frameworks Version: 5.49.0
Operating System: Linux 4.17.14-gentoo-p9_dma-zfs ppc64le
Distribution: "Gentoo Base System release 2.4.1"

-- Information about the crash:
- What I was doing when the application crashed:

It seems to crash in at least these cases:
- Connection times out
- "Disconnect" button clicked during initial connection

The crash can be reproduced every time.
Comment 1 tildearrow 2020-11-05 07:38:21 UTC
Reproduced. Steps to Reproduce:

1. Connect to a host that is down.
2. Press Disconnect.
3. Repeat 1 and 2 several times.
4. After a while, something happens and KRDC crashes.
Comment 2 Lamarque V. Souza 2021-03-12 15:30:40 UTC
Git commit ba6baad9b49a8a7fe57f27046631fc00c177e1a0 by Lamarque V. Souza.
Committed on 12/03/2021 at 15:26.
Pushed by lvsouza into branch 'fix_crash_on_disconnect'.

Fix crash when closing a tab.

TabbedViewWidget::removePage is called twice for the same page, which
leads to crash on the second run. It is called by those two signals in
mainwindow.cpp:

connect(disconnectAction, SIGNAL(triggered()), SLOT(disconnectHost()));
connect(view, SIGNAL(disconnected()), this, SLOT(disconnectHost()));

M  +3    -0    tabbedviewwidget.cpp

https://invent.kde.org/network/krdc/commit/ba6baad9b49a8a7fe57f27046631fc00c177e1a0