| Summary: | SimpleKCM: flickable.contentHeight evaluates to 0, causing KCMs using this template to have windows that are too small when opened in kcmshell | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kdeclarative | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, claudius.ellsel, dufferzafar0, jazzvoid, kdelibs-bugs, medhefgo, tigrangab+kdebugs |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=389585 https://bugs.kde.org/show_bug.cgi?id=398802 https://bugs.kde.org/show_bug.cgi?id=399767 https://bugs.kde.org/show_bug.cgi?id=398801 https://bugs.kde.org/show_bug.cgi?id=398794 https://bugs.kde.org/show_bug.cgi?id=398796 |
||
| Latest Commit: | https://cgit.kde.org/kdeclarative.git/commit/?id=d9a0365ccc49e6d451ed1b2903876ca28cec9737 | Version Fixed In: | 5.58 |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2018-09-18 20:55:12 UTC
*** Bug 398794 has been marked as a duplicate of this bug. *** *** Bug 398801 has been marked as a duplicate of this bug. *** *** Bug 398802 has been marked as a duplicate of this bug. *** *** Bug 398796 has been marked as a duplicate of this bug. *** *** Bug 399767 has been marked as a duplicate of this bug. *** *** Bug 401163 has been marked as a duplicate of this bug. *** *** Bug 401583 has been marked as a duplicate of this bug. *** This bug persists. :( Operating System: Arch Linux KDE Plasma Version: 5.15.2 KDE Frameworks Version: 5.55.0 Qt Version: 5.12.1 I changed:
width: units.gridUnit * 25
height: !!currentBattery ? units.gridUnit * 25 : units.gridUnit * 12
from energyinfo module's main.qml in kinfocenter to:
implicitWidth: units.gridUnit * 25
implicitHeight: !!currentBattery ? units.gridUnit * 25 : units.gridUnit * 12
and the window now adjusts to the size provided.
Same behavior observed with file index manager.
I don't know the significance of that as I'm new to kde/qt, just reporting what I observed so far.
That's a very nice find, and sounds like the correct fix to me. Would you like to submit some patches for these? I can help if anything on https://community.kde.org/Get_Involved/development or https://community.kde.org/Infrastructure/Phabricator Sure, I can work on it. Git commit 43bfb812df95ddddb3e33107e2ba5fc9e1680332 by Aleix Pol, on behalf of Tigran Gabrielyan. Committed on 25/03/2019 at 11:14. Pushed by apol into branch 'master'. Fix initial width/height in KCMs that use qml Summary: This change fixes width/height for File Index Manager and Energy Information modules. Reviewers: apol Reviewed By: apol Subscribers: ngraham, apol, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D20027 M +2 -2 Modules/energy/package/contents/ui/main.qml M +3 -0 Modules/fileindexermonitor/package/contents/ui/main.qml https://commits.kde.org/kinfocenter/43bfb812df95ddddb3e33107e2ba5fc9e1680332 This bug persists. Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.15.80 KDE Frameworks Version: 5.57.0 Qt Version: 5.12.0 For which KCMs? fonts workspace launch feedback mouse (libinput) touchpad (libinput) Found the generic problem in https://cgit.kde.org/kdeclarative.git/tree/src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml#n51 flickable.contentHeight is always 0 for some reason. Some individual KCMs may need their own fixes beyond that but this is the root cause of the problems with our KCMs that use the SimpleKCM template. Partial patch: https://phabricator.kde.org/D20283 Fixed with: - https://cgit.kde.org/kcmutils.git/commit/?id=21b1cd906807f9c8dc1dbef4374d01ea78f6524e - https://cgit.kde.org/kirigami.git/commit/?id=6019ae96a68a6457748f4a2c19385390a9ed18fd - https://cgit.kde.org/kirigami.git/commit/?id=3b4643b55257aca728438607a023532e929d7278 - https://cgit.kde.org/kirigami.git/commit/?id=f604477459a2b9023a17b0cd2c401d104caf142b - https://cgit.kde.org/kdeclarative.git/commit/?id=d9a0365ccc49e6d451ed1b2903876ca28cec9737 *** Bug 398802 has been marked as a duplicate of this bug. *** *** Bug 399767 has been marked as a duplicate of this bug. *** *** Bug 398801 has been marked as a duplicate of this bug. *** *** Bug 398794 has been marked as a duplicate of this bug. *** *** Bug 398796 has been marked as a duplicate of this bug. *** |