| Summary: | Falkon crashes after hitting "remember password" | ||
|---|---|---|---|
| Product: | [Applications] Falkon | Reporter: | Tony <jodr666> |
| Component: | general | Assignee: | David Rosca <nowrep> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | Fethrblaka13, jurajoravec, kde.bugs, wbauer1 |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
New crash information added by DrKonqi
New crash information added by DrKonqi |
||
|
Description
Tony
2018-09-17 16:45:56 UTC
(In reply to Tony from comment #0) > Thread 1 (Thread 0x7f26f51939c0 (LWP 17010)): > [KCrash Handler] > #6 0x00007f26d80303c8 in KWalletPasswordBackend::addEntry(PasswordEntry > const&) () from /usr/lib64/qt5/plugins/falkon/KDEFrameworksIntegration.so The crash happens if you use KWallet as backend for saving passwords, and the kwallet cannot be opened for some reason. You'll likely get "KWalletPasswordBackend::initialize Cannot open wallet!" errors too if you start falkon in Konsole... Check that you didn't disable kwallet in systemsettings5->Account Details->KDE Wallet. (switching back to the standard password storage in Falkon's settings would help too of course) Falkon should check if opening the wallet succeeded though and not try to use it if it failed. (In reply to Wolfgang Bauer from comment #1) > (In reply to Tony from comment #0) > > Thread 1 (Thread 0x7f26f51939c0 (LWP 17010)): > > [KCrash Handler] > > #6 0x00007f26d80303c8 in KWalletPasswordBackend::addEntry(PasswordEntry > > const&) () from /usr/lib64/qt5/plugins/falkon/KDEFrameworksIntegration.so > > The crash happens if you use KWallet as backend for saving passwords, and > the kwallet cannot be opened for some reason. > You'll likely get "KWalletPasswordBackend::initialize Cannot open wallet!" > errors too if you start falkon in Konsole... > > Check that you didn't disable kwallet in systemsettings5->Account > Details->KDE Wallet. (switching back to the standard password storage in > Falkon's settings would help too of course) > > Falkon should check if opening the wallet succeeded though and not try to > use it if it failed. I do have kwallet off, don't use at all. (In reply to Tony from comment #2) > I do have kwallet off, don't use at all. And that causes the crash. In 3.1.0 (and probably already 3.0.99 that was reported against), Falkon automatically enables the KWallet integration when run on Plasma, as a ficx for bug#391304. Unfortunately, it does so on every start, so you need to disable the KDE integration plugin completely to disable the usage of kwallet, as I noticed meanwhile... Created attachment 124197 [details]
New crash information added by DrKonqi
falkon (3.1.0) using Qt 5.12.5
- What I was doing when the application crashed:
Clicking the 'Remember' button to save the login credentials for a website
------------
May be related: The "KDE Frameworks Integration" extension is enabled and:
$ cat ~/.config/kwalletrc
[Wallet]
Enabled=false
-- Backtrace (Reduced):
#6 0x00007fbbd445ddd2 in KWalletPasswordBackend::addEntry(PasswordEntry const&) () at /usr/lib64/qt5/plugins/falkon/KDEFrameworksIntegration.so
#7 0x00007fbc02864600 in AutoFill::addEntry(QUrl const&, PageFormData const&) () at /usr/lib64/libFalkonPrivate.so.3
#8 0x00007fbc02866a11 in AutoFillNotification::remember() () at /usr/lib64/libFalkonPrivate.so.3
[...]
#10 0x00007fbc022f1992 in QAbstractButton::clicked(bool) () at /usr/lib64/libQt5Widgets.so.5
#11 0x00007fbc022f1baa in () at /usr/lib64/libQt5Widgets.so.5
I've confirmed that the issue does not occur in my case after setting up kwallet. Created attachment 124957 [details]
New crash information added by DrKonqi
falkon (3.1.0) using Qt 5.12.5
- What I was doing when the application crashed:
Clicked remember password
- Custom settings of the application:
KDE wallet services was stoped
-- Backtrace (Reduced):
#6 0x00007fa684219aa7 in KWalletPasswordBackend::addEntry(PasswordEntry const&) () from /usr/lib/x86_64-linux-gnu/qt5/plugins/falkon/KDEFrameworksIntegration.so
#7 0x00007fa6b78e2a23 in AutoFill::addEntry(QUrl const&, PageFormData const&) () from /lib/x86_64-linux-gnu/libFalkonPrivate.so.3
#8 0x00007fa6b78e4d51 in AutoFillNotification::remember() () from /lib/x86_64-linux-gnu/libFalkonPrivate.so.3
[...]
#10 0x00007fa6b737a312 in QAbstractButton::clicked(bool) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
[...]
#13 0x00007fa6b737ba95 in QAbstractButton::mouseReleaseEvent(QMouseEvent*) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
The code assumes kwallet is always working and there is no problem at all. It will ALWAYS try to use it. In other words it needs a bit of work. Anyone up to a challenge? At worst I will look at it, now that I know where the problem is. Seems that it should have been fixed by https://cgit.kde.org/falkon.git/commit/?id=1cecd14fd069ff778224fe778b7117cb4e3bc0ee, but I haven't tried it yet. (In reply to Wolfgang Bauer from comment #8) > Seems that it should have been fixed by > https://cgit.kde.org/falkon.git/commit/ > ?id=1cecd14fd069ff778224fe778b7117cb4e3bc0ee, but I haven't tried it yet. It should not crash now when kwallet is disabled, but there is still some room for improvements. |