| Summary: | Untranslatable strings in debug_console.ui | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Alexander Potashev <aspotashev> |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde |
| Priority: | NOR | Flags: | kde:
ReviewRequest+
|
| Version First Reported In: | 5.13.4 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kwin/8bba7009bca27aff38136e52908326d179647a89 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Alexander Potashev
2018-09-16 10:27:22 UTC
Debug console is not for end users, nor accessible from the ui. Is it worth translators time? It's accessible through KRunner if you type in "KWin debug console". We already translate strings from debug_console.cpp (they are extracted into kwin.pot), these should be "citizens" of the same class. I wrote a patch but phabricator is down. If you want to review here: diff --git a/Messages.sh b/Messages.sh index 477aa7630..004d0af4b 100644 --- a/Messages.sh +++ b/Messages.sh @@ -1,3 +1,3 @@ #! /usr/bin/env bash -$EXTRACTRC *.kcfg >> rc.cpp +$EXTRACTRC *.kcfg *.ui >> rc.cpp (In reply to David Edmundson from comment #3) > diff --git a/Messages.sh b/Messages.sh > index 477aa7630..004d0af4b 100644 > --- a/Messages.sh > +++ b/Messages.sh > @@ -1,3 +1,3 @@ > #! /usr/bin/env bash > -$EXTRACTRC *.kcfg >> rc.cpp > +$EXTRACTRC *.kcfg *.ui >> rc.cpp This should work. Thanks! Git commit 8bba7009bca27aff38136e52908326d179647a89 by David Edmundson. Committed on 17/09/2018 at 09:39. Pushed by davidedmundson into branch 'Plasma/5.14'. Fix untranslatable strings in debug_console.ui shortcutdialog.ui Review on bugzilla M +1 -1 Messages.sh https://commits.kde.org/kwin/8bba7009bca27aff38136e52908326d179647a89 |