Bug 398515

Summary:	FindMusicBrainz5.cmake: MUSICBRAINZ5_INCLUDE_DIRS not used or searched for anymore (regression)
Product:	[Frameworks and Libraries] libkcddb	Reporter:	Rex Dieter <rdieter>
Component:	general	Assignee:	Richard Lärkäng <larkang>
Status:	CONFIRMED ---
Severity:	normal	CC:	myriam, sitter, tdfischer
Priority:	NOR	Keywords:	regression
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Rex Dieter 2018-09-11 19:31:37 UTC

Since merge of kf5 branch, lost the effective modifcation from past commit

https://cgit.kde.org/libkcddb.git/commit/cmake/FindMusicBrainz5.cmake?id=a6ef64de33a84d4842659241d8bda3b12190f8ca

to support (multiple) include dirs, so builds will effectively use
$ pkg-config --cflags libmusicbrainz5
(output on my box includes:
-I/usr/include/neon -I/usr/include/libxml2
)

I noticed this primarily because libkcddb fails to build on RHEL7 without that.

Comment 1 Rex Dieter 2018-09-11 20:31:40 UTC

Or can just live with this and require libmusticbrainz >= 5.1 where the strict dependency on libxml2 was dropped.

(And I can just workaround it downstream by manually adding include dirs as needed)

Comment 2 Christoph Feck 2018-10-03 21:03:38 UTC

Would include_directories(${MUSICBRAINZ5_INCLUDE_DIRS}) help when MUSICBRAINZ5_FOUND?