Bug 398473

Summary: powerdevil does not compile with >=ddcutil-0.8.6
Product: [Plasma] Powerdevil Reporter: Hannes Schweizer <nilathak>
Component: generalAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: kde
Priority: NOR    
Version: 5.13.5   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In:

Description Hannes Schweizer 2018-09-11 00:25:16 UTC 
The current ddcutilbrightness.cpp implementation has been broken since the following ddcutil commit:
https://github.com/rockowitz/ddcutil/commit/3276de053ec2b3771213f14f7dddba569b82e16f

After fixing a minor issue in a CMakeLists file of powerdevil-5.11.2, I was able to successfully enable the brightness control using ddcutil-0.8.4. I was eagerly waiting for the CMakeLists patch to make it into powerdevil-5.13 (https://phabricator.kde.org/D8626?id=33105), but obviously it didn't.

However after fixing the CMakeLists of powerdevil-5.13 locally again, I'm no longer able to compile:
powerdevil-5.13.5 + >=ddcutil-0.8.6 + gcc-8.2.0 => FAIL due to ddcutil API changes
powerdevil-5.13.5 + <ddcutil-0.8.6 + gcc-8.2.0 => FAIL ddcutil needs <gcc-7

I've updated ddcutilbrightness.cpp for ddcutil-0.9.1 and now everything works again!

Here's the diff:
https://github.com/nilathak/powerdevil/commit/74b679d773639cac34d5730cd007e9d59130d6f7
Comment 1 Kai Uwe Broulik 2018-09-11 06:54:20 UTC 
Thanks a lot for your investigation! Can you please upload this patch to https://phabricator.kde.org/ for review? We do not use GitHub for pull requests or issue tracking.
Comment 2 Christoph Feck 2018-10-04 22:45:37 UTC 
Hannes, any success with https://phabricator.kde.org/differential/diff/create/ ? We have more documentation at https://community.kde.org/Infrastructure/Phabricator
Comment 3 Hannes Schweizer 2020-10-25 12:48:20 UTC 
Sry for the massively delayed response...

The problem has been fixed in the meantime:
kde-plasma/powerdevil-5.20.1
app-misc/ddcutil-0.9.9