| Summary: | Crash caused by color custimization | ||
|---|---|---|---|
| Product: | [Applications] korganizer | Reporter: | Denis Kurz <kdenis> |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | jv3303, s.zb |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | 5.9.1 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/akonadi/9d83f0752828942789535b1d0dc0ddc3c8b479bd | Version Fixed In: | 5.9.3 |
| Sentry Crash Report: | |||
| Attachments: | New crash information added by DrKonqi | ||
|
Description
Denis Kurz
2018-09-10 13:55:39 UTC
Created attachment 115562 [details]
New crash information added by DrKonqi
korganizer (5.9.1) using Qt 5.11.1
- What I was doing when the application crashed: In KOrganizer, I changed the color of an event category via Settings > Configure KOrganizer > Colors and Fonts. When I clicked 'Apply' it crashed the application, telling me that it closed unexpectedly. I was able to reproduce this behaviour three more times immediately after.
It appears that KOrganizer crashes every time when I'm doing this. It does however save the new category color and I can apply it to my events just fine.
- Custom settings of the application:
I did change the location of my .ics-file and put it in my Spideroak-folder within my Home folder (Spideroak being a Dropbox-like cloud syncing program), in order to have a synchronized version of my calendar on multiple devices.
-- Backtrace (Reduced):
#6 std::__atomic_base<int>::load (__m=std::memory_order_relaxed, this=0x18) at /usr/include/c++/7/bits/atomic_base.h:396
#7 QAtomicOps<int>::load<int> (_q_value=...) at ../../include/QtCore/../../src/corelib/thread/qatomic_cxx11.h:227
#8 QBasicAtomicInteger<int>::load (this=0x18) at ../../include/QtCore/../../src/corelib/thread/qbasicatomic.h:103
[...]
#10 0x00007f77e4e0e2d4 in QVector<QPersistentModelIndexData*>::QVector (this=0x7ffc5ad51fd0, v=...) at ../../include/QtCore/../../src/corelib/tools/qvector.h:358
#11 0x00007f77e4e0ef8a in QStack<QVector<QPersistentModelIndexData*> >::pop (this=this@entry=0x560ce043a670) at ../../include/QtCore/../../src/corelib/tools/qstack.h:62
This will hopefully be fixed in version 5.9.3 due to this: https://phabricator.kde.org/D16051 Git commit 9d83f0752828942789535b1d0dc0ddc3c8b479bd by Denis Kurz. Committed on 11/10/2018 at 21:23. Pushed by dkurz into branch 'Applications/18.08'. Fix KOrg category color customization crash Summary: Use default value for NULL columns. Without this patch, possibly different default values are used for entity construction (default from akonadidb.xml) and when reading a row from the database (default-constructed), resulting in inconsistencies. For example, when modifying a Tag, the resulting Tag modify notification indicates that the new parentId of the modified Tag is 0 (default-constructed qint64), whereas Tags without parents are initialized with parentId -1. This patch fixes these inconsistencies by considering the "default" value from akonadidb.xml for row-to-entity conversion, too. Set default Tag::parentId to -1. A parentless Tag is initialized with parentId -1, so we should also report that when reading a Tag from the database where the parentId field is NULL. FIXED-IN: 5.9.3 Test Plan: KOrganizer stops crashing on category color customization with this patch. More detailed test plan suggestions welcome. Reviewers: #kde_pim, dvratil Reviewed By: #kde_pim, dvratil Subscribers: dvratil, kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D16051 M +2 -2 src/server/storage/akonadidb.xml M +1 -1 src/server/storage/entities.xsl https://commits.kde.org/akonadi/9d83f0752828942789535b1d0dc0ddc3c8b479bd *** Bug 400220 has been marked as a duplicate of this bug. *** |