Bug 398390

Summary:	Use icon for "Configure" menu item
Product:	[Frameworks and Libraries] frameworks-knewstuff	Reporter:	isalliswell <rahul.vit2014>
Component:	general	Assignee:	Jeremy Whiting <jpwhiting>
Status:	RESOLVED FIXED
Severity:	normal	CC:	elvis.angelaccio, kdelibs-bugs-null, nate
Priority:	NOR
Version First Reported In:	5.50.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/knewstuff/49533c532291e8dd696e447ae6831c4d41088a08	Version Fixed/Implemented In:	5.51
Sentry Crash Report:

Description isalliswell 2018-09-08 08:40:44 UTC

Please have a look at the screenshot below:

https://i.imgur.com/jIn3kDr.jpg

The "Configure" should be unified and I think it would be better to show icons for all the suggested applications or for none.In the attached screenshot you can see an icon is shown beside Gparted and Filelight only and not for others like KDE Partition Manager etc.

Comment 1 Nate Graham 2018-09-13 17:30:30 UTC

> I think it would be better to show icons for all the suggested applications
> or for none
Please file a new bug for frameworks-knewstuff listing the entries are missing icons so we can fix them.


> The "Configure" should be unified
Can you clarify what you mean here? Might be fixed by https://phabricator.kde.org/D13880

Comment 2 isalliswell 2018-09-14 09:04:23 UTC

(In reply to Nate Graham from comment #1)

> Please file a new bug for frameworks-knewstuff listing the entries are
> missing icons so we can fix them.

Ok,I will do it.

> > The "Configure" should be unified
> Can you clarify what you mean here?

I mean the icon should be same as other "Configure" icons throughout the desktop i.e. "(little settings icon) Configure..." .

Comment 3 Nate Graham 2018-09-14 22:23:06 UTC

Makes sense now, thanks.

Comment 4 Nate Graham 2018-09-16 14:08:05 UTC

Git commit 49533c532291e8dd696e447ae6831c4d41088a08 by Nathaniel Graham.
Committed on 16/09/2018 at 14:07.
Pushed by ngraham into branch 'master'.

[KMoreTools] give the "Configure..." menu item an appropriate icon
FIXED-IN: 5.51

M  +1    -1    src/kmoretools/kmoretools.cpp

https://commits.kde.org/knewstuff/49533c532291e8dd696e447ae6831c4d41088a08