Summary: | konsole crashes sometimes when selecting or pasting text while pressing shift key | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | cybea <kde-bugs> |
Component: | general | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | bizyaev, eatkin, kde-bugs, martin.sandsmark, matan, mzipay, nate, support.gulp21+kde |
Priority: | NOR | Keywords: | drkonqi |
Version: | 22.08.0 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/utilities/konsole/commit/4cbe74476820d96421627689ac66a596381c74e5 | Version Fixed In: | 20.08.2 |
Attachments: |
New crash information added by DrKonqi
New crash information added by DrKonqi New crash information added by DrKonqi New crash information added by DrKonqi New crash information added by DrKonqi Fix New crash information added by DrKonqi New crash information added by DrKonqi attachment-32512-0.html |
Description
cybea
2018-09-06 11:54:34 UTC
additional notes: - this happens since ~1 Month ago. I always keep my system uptodate. (kde-neon user edition) - I always work with multiple konsole windows and tabs - this bug is really annoying and makes work with konsole a pain Created attachment 114856 [details]
New crash information added by DrKonqi
konsole (18.08.1) using Qt 5.11.1
- What I was doing when the application crashed:
Starting a block selection using Ctrl+Shift+Alt (instead of just Ctrl+Alt) while the prompt was off-screen (i.e. scrolled some way up). I cannot always reproduce the crash, but I can say that it is unrelated to vim. Started to experience that crash a few weeks ago.
-- Backtrace (Reduced):
#6 0x00007f6c40c03ffc in std::__atomic_base<int>::load (__m=std::memory_order_relaxed, this=0x0) at /usr/include/c++/5/bits/atomic_base.h:396
#7 QAtomicOps<int>::load<int> (_q_value=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qatomic_cxx11.h:227
#8 QBasicAtomicInteger<int>::load (this=0x0) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qbasicatomic.h:103
#9 QtPrivate::RefCount::isShared (this=0x0) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qrefcount.h:101
#10 QVector<Konsole::Character>::isDetached (this=0x1c2c748) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:106
Created attachment 114897 [details]
New crash information added by DrKonqi
konsole (18.08.1) using Qt 5.11.1
- What I was doing when the application crashed:
again I worked via ssh in vim and selected text pressing shift-key (forgot to mention vim via ssh last time)
-- Backtrace (Reduced):
#6 0x00007efe46be6ffc in std::__atomic_base<int>::load (__m=std::memory_order_relaxed, this=0x280) at /usr/include/c++/5/bits/atomic_base.h:396
#7 QAtomicOps<int>::load<int> (_q_value=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qatomic_cxx11.h:227
#8 QBasicAtomicInteger<int>::load (this=0x280) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qbasicatomic.h:103
#9 QtPrivate::RefCount::isShared (this=0x280) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qrefcount.h:101
#10 QVector<Konsole::Character>::isDetached (this=0x2f5db30) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:106
konsole crashed again while selecting text in vim pressing shift key - no ssh involved Latest crash (in above comment #4) using KDE Plasma Version: 5.13.5 Frameworks Version: 5.50.0 Qt Version: 5.11.1 Created attachment 115123 [details]
New crash information added by DrKonqi
konsole (18.08.1) using Qt 5.11.1
- What I was doing when the application crashed:
did: git commit
in vim edited message and then tryed to select text in command mode pressing shift key
-- Backtrace (Reduced):
#6 0x00007f85ae835ffc in std::__atomic_base<int>::load (__m=std::memory_order_relaxed, this=0x5f0053454c4946) at /usr/include/c++/5/bits/atomic_base.h:396
#7 QAtomicOps<int>::load<int> (_q_value=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qatomic_cxx11.h:227
#8 QBasicAtomicInteger<int>::load (this=0x5f0053454c4946) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qbasicatomic.h:103
#9 QtPrivate::RefCount::isShared (this=0x5f0053454c4946) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qrefcount.h:101
#10 QVector<Konsole::Character>::isDetached (this=0x1dc14f0) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:106
Created attachment 115267 [details]
New crash information added by DrKonqi
konsole (18.08.1) using Qt 5.11.1
- What I was doing when the application crashed:
this time used ssh + vim and /double clicked/ while pressing shift
---
Plasma Version: 5.13.5
-- Backtrace (Reduced):
#6 0x00007f81e6bd8ffc in std::__atomic_base<int>::load (__m=std::memory_order_relaxed, this=0x100010001002f) at /usr/include/c++/5/bits/atomic_base.h:396
#7 QAtomicOps<int>::load<int> (_q_value=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qatomic_cxx11.h:227
#8 QBasicAtomicInteger<int>::load (this=0x100010001002f) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qbasicatomic.h:103
#9 QtPrivate::RefCount::isShared (this=0x100010001002f) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qrefcount.h:101
#10 QVector<Konsole::Character>::isDetached (this=0x1108b40) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:106
correction of last comment: no ssh but editing of git commit message Created attachment 115368 [details]
New crash information added by DrKonqi
konsole (18.08.1) using Qt 5.11.1
- What I was doing when the application crashed:
selecting text in vim in local file system pressing shift key
(still the same after update of kde-neon's ubuntu base to 18.04 bionic)
-- Backtrace (Reduced):
#6 0x00007fd94592d2f9 in std::__atomic_base<int>::load (__m=std::memory_order_relaxed, this=0x51) at /usr/include/c++/7/bits/atomic_base.h:396
#7 QAtomicOps<int>::load<int> (_q_value=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qatomic_cxx11.h:227
#8 QBasicAtomicInteger<int>::load (this=0x51) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qbasicatomic.h:103
#9 QtPrivate::RefCount::isShared (this=0x51) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qrefcount.h:101
#10 QVector<Konsole::Character>::isDetached (this=0x559f00b90128) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:106
All backtraces are identical, there is no need to add more of them. introduced by fcea6742c142fdbfdf53d17c862bfae7652fae3b, I think, that removed a check where it crashes. reverting that should fix it. Git commit 5006d0e194d642d8059e15edf9704fd38b579979 by Martin T. H. Sandsmark. Committed on 08/10/2018 at 12:19. Pushed by sandsmark into branch 'master'. Re-introduce bounds check removed in fcea6742c142fdbfdf53d17c862bfae7652fae3b https://phabricator.kde.org/D16010 M +2 -0 src/Screen.cpp https://commits.kde.org/konsole/5006d0e194d642d8059e15edf9704fd38b579979 Why does this bugfix doesn't get "backported" to 18.08? To me it seems like a trivial patch for an annoying crash. What I did to get my assumption: $ git clone git://anongit.kde.org/konsole $ cd konsole $ git branch -r --contains 5006d0e194d642d8059e15edf9704fd38b579979 origin/HEAD -> origin/master origin/martin/inactivebg origin/master *** Bug 402267 has been marked as a duplicate of this bug. *** *** Bug 406999 has been marked as a duplicate of this bug. *** *** Bug 426242 has been marked as a duplicate of this bug. *** It's back again. Consistent way to reproduce: 1: Generate enough scrollback to scroll up 2: Scroll up and select something 3: Start something that uses the alternate screen buffer (e. g. vim) 4: Hold down shift and press the mouse button (to start a new selection) Created attachment 131446 [details]
Fix
This fixes it here by invalidating the selection in TerminalDisplay when switching Screen.
I'm not sure why they duplicate the beginning of the selection, but this is the simplest solution at least.
A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/207 Git commit 9bb6e3febe82a56b4cc02bee8a15030dc8cedde7 by Martin T. H. Sandsmark. Committed on 06/09/2020 at 12:18. Pushed by hindenburg into branch 'master'. Fix crash when extending selection after switching between primary and secondary screen M +5 -0 src/ScreenWindow.cpp M +5 -0 src/ScreenWindow.h M +5 -0 src/widgets/TerminalDisplay.cpp https://invent.kde.org/utilities/konsole/commit/9bb6e3febe82a56b4cc02bee8a15030dc8cedde7 Git commit 4cbe74476820d96421627689ac66a596381c74e5 by Kurt Hindenburg, on behalf of Martin T. H. Sandsmark. Committed on 06/09/2020 at 14:09. Pushed by hindenburg into branch 'release/20.08'. Fix crash when extending selection after switching between primary and secondary screen FIXED-IN: 20.08.2 (cherry picked from commit 9bb6e3febe82a56b4cc02bee8a15030dc8cedde7) M +5 -0 src/ScreenWindow.cpp M +5 -0 src/ScreenWindow.h M +5 -0 src/TerminalDisplay.cpp https://invent.kde.org/utilities/konsole/commit/4cbe74476820d96421627689ac66a596381c74e5 Created attachment 151485 [details]
New crash information added by DrKonqi
konsole (22.08.0) using Qt 5.15.5
I won't be able to reproduce this consistently, but I just had Konsole 22.08 crash with a similar stack trace while selecting text with the Shift key pressed.
-- Backtrace (Reduced):
#4 0x00007f86bd779474 in std::__atomic_base<int>::load (__m=std::memory_order_relaxed, this=0x0) at /usr/include/c++/7/bits/atomic_base.h:396
#5 QAtomicOps<int>::loadRelaxed<int> (_q_value=...) at /usr/include/qt5/QtCore/qatomic_cxx11.h:239
#6 QBasicAtomicInteger<int>::loadRelaxed (this=0x0) at /usr/include/qt5/QtCore/qbasicatomic.h:107
#7 QtPrivate::RefCount::isShared (this=0x0) at /usr/include/qt5/QtCore/qrefcount.h:101
#8 QVector<Konsole::Character>::isDetached (this=0x5577df78f208) at /usr/include/qt5/QtCore/qvector.h:113
Created attachment 152622 [details]
New crash information added by DrKonqi
konsole (22.08.1) using Qt 5.15.6
I was holding down shift to highlight some text in gvim when the crash occurred.
-- Backtrace (Reduced):
#7 0x00007fa93ab8b112 in std::__glibcxx_assert_fail (file=<optimized out>, line=<optimized out>, function=<optimized out>, condition=<optimized out>) at /usr/src/debug/gcc/libstdc++-v3/src/c++11/debug.cc:60
#8 0x00007fa93c205690 in Konsole::Screen::setSelectionEnd(int, int, bool) () from /usr/lib/libkonsoleprivate.so.1
#9 0x00007fa93c261153 in Konsole::TerminalDisplay::extendSelection(QPoint const&) () from /usr/lib/libkonsoleprivate.so.1
#10 0x00007fa93c265d8a in Konsole::TerminalDisplay::mousePressEvent(QMouseEvent*) () from /usr/lib/libkonsoleprivate.so.1
#11 0x00007fa93bad845b in QWidget::event(QEvent*) () from /usr/lib/libQt5Widgets.so.5
(In reply to Ilya Bizyaev from comment #23) > Created attachment 151485 [details] > New crash information added by DrKonqi > > konsole (22.08.0) using Qt 5.15.5 > > I won't be able to reproduce this consistently, but I just had Konsole 22.08 > crash with a similar stack trace while selecting text with the Shift key > pressed. > > -- Backtrace (Reduced): > #4 0x00007f86bd779474 in std::__atomic_base<int>::load > (__m=std::memory_order_relaxed, this=0x0) at > /usr/include/c++/7/bits/atomic_base.h:396 > #5 QAtomicOps<int>::loadRelaxed<int> (_q_value=...) at > /usr/include/qt5/QtCore/qatomic_cxx11.h:239 > #6 QBasicAtomicInteger<int>::loadRelaxed (this=0x0) at > /usr/include/qt5/QtCore/qbasicatomic.h:107 > #7 QtPrivate::RefCount::isShared (this=0x0) at > /usr/include/qt5/QtCore/qrefcount.h:101 > #8 QVector<Konsole::Character>::isDetached (this=0x5577df78f208) at > /usr/include/qt5/QtCore/qvector.h:113 Can you tell what was the terminal size when the crash occured? Specifically, how many lines it had?(In reply to Ilya Bizyaev from comment #23) > Created attachment 151485 [details] > New crash information added by DrKonqi > > konsole (22.08.0) using Qt 5.15.5 > > I won't be able to reproduce this consistently, but I just had Konsole 22.08 > crash with a similar stack trace while selecting text with the Shift key > pressed. > > -- Backtrace (Reduced): > #4 0x00007f86bd779474 in std::__atomic_base<int>::load > (__m=std::memory_order_relaxed, this=0x0) at > /usr/include/c++/7/bits/atomic_base.h:396 > #5 QAtomicOps<int>::loadRelaxed<int> (_q_value=...) at > /usr/include/qt5/QtCore/qatomic_cxx11.h:239 > #6 QBasicAtomicInteger<int>::loadRelaxed (this=0x0) at > /usr/include/qt5/QtCore/qbasicatomic.h:107 > #7 QtPrivate::RefCount::isShared (this=0x0) at > /usr/include/qt5/QtCore/qrefcount.h:101 > #8 QVector<Konsole::Character>::isDetached (this=0x5577df78f208) at > /usr/include/qt5/QtCore/qvector.h:113 Can you tell the (In reply to Ilya Bizyaev from comment #23) > Created attachment 151485 [details] > New crash information added by DrKonqi > > konsole (22.08.0) using Qt 5.15.5 > > I won't be able to reproduce this consistently, but I just had Konsole 22.08 > crash with a similar stack trace while selecting text with the Shift key > pressed. > > -- Backtrace (Reduced): > #4 0x00007f86bd779474 in std::__atomic_base<int>::load > (__m=std::memory_order_relaxed, this=0x0) at > /usr/include/c++/7/bits/atomic_base.h:396 > #5 QAtomicOps<int>::loadRelaxed<int> (_q_value=...) at > /usr/include/qt5/QtCore/qatomic_cxx11.h:239 > #6 QBasicAtomicInteger<int>::loadRelaxed (this=0x0) at > /usr/include/qt5/QtCore/qbasicatomic.h:107 > #7 QtPrivate::RefCount::isShared (this=0x0) at > /usr/include/qt5/QtCore/qrefcount.h:101 > #8 QVector<Konsole::Character>::isDetached (this=0x5577df78f208) at > /usr/include/qt5/QtCore/qvector.h:113 Can you tell what was the terminal size when the crash happened? Specifically, what was the terminal height? Were you using a full terminal application (like vi), or in command line? A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/754 Created attachment 152689 [details] attachment-32512-0.html I believe the terminal height was 45 lines. I was using VIM on a remote host via ssh session. On Sat, Oct 8, 2022 at 3:35 AM Matan Ziv-Av <bugzilla_noreply@kde.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=398320 > > Matan Ziv-Av <matan@svgalib.org> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > CC| |matan@svgalib.org > > --- Comment #25 from Matan Ziv-Av <matan@svgalib.org> --- > (In reply to Ilya Bizyaev from comment #23) > > Created attachment 151485 [details] > > New crash information added by DrKonqi > > > > konsole (22.08.0) using Qt 5.15.5 > > > > I won't be able to reproduce this consistently, but I just had Konsole > 22.08 > > crash with a similar stack trace while selecting text with the Shift key > > pressed. > > > > -- Backtrace (Reduced): > > #4 0x00007f86bd779474 in std::__atomic_base<int>::load > > (__m=std::memory_order_relaxed, this=0x0) at > > /usr/include/c++/7/bits/atomic_base.h:396 > > #5 QAtomicOps<int>::loadRelaxed<int> (_q_value=...) at > > /usr/include/qt5/QtCore/qatomic_cxx11.h:239 > > #6 QBasicAtomicInteger<int>::loadRelaxed (this=0x0) at > > /usr/include/qt5/QtCore/qbasicatomic.h:107 > > #7 QtPrivate::RefCount::isShared (this=0x0) at > > /usr/include/qt5/QtCore/qrefcount.h:101 > > #8 QVector<Konsole::Character>::isDetached (this=0x5577df78f208) at > > /usr/include/qt5/QtCore/qvector.h:113 > > Can you tell what was the terminal size when the crash occured? > Specifically, > how many lines it had?(In reply to Ilya Bizyaev from comment #23) > > Created attachment 151485 [details] > > New crash information added by DrKonqi > > > > konsole (22.08.0) using Qt 5.15.5 > > > > I won't be able to reproduce this consistently, but I just had Konsole > 22.08 > > crash with a similar stack trace while selecting text with the Shift key > > pressed. > > > > -- Backtrace (Reduced): > > #4 0x00007f86bd779474 in std::__atomic_base<int>::load > > (__m=std::memory_order_relaxed, this=0x0) at > > /usr/include/c++/7/bits/atomic_base.h:396 > > #5 QAtomicOps<int>::loadRelaxed<int> (_q_value=...) at > > /usr/include/qt5/QtCore/qatomic_cxx11.h:239 > > #6 QBasicAtomicInteger<int>::loadRelaxed (this=0x0) at > > /usr/include/qt5/QtCore/qbasicatomic.h:107 > > #7 QtPrivate::RefCount::isShared (this=0x0) at > > /usr/include/qt5/QtCore/qrefcount.h:101 > > #8 QVector<Konsole::Character>::isDetached (this=0x5577df78f208) at > > /usr/include/qt5/QtCore/qvector.h:113 > > Can you tell the (In reply to Ilya Bizyaev from comment #23) > > Created attachment 151485 [details] > > New crash information added by DrKonqi > > > > konsole (22.08.0) using Qt 5.15.5 > > > > I won't be able to reproduce this consistently, but I just had Konsole > 22.08 > > crash with a similar stack trace while selecting text with the Shift key > > pressed. > > > > -- Backtrace (Reduced): > > #4 0x00007f86bd779474 in std::__atomic_base<int>::load > > (__m=std::memory_order_relaxed, this=0x0) at > > /usr/include/c++/7/bits/atomic_base.h:396 > > #5 QAtomicOps<int>::loadRelaxed<int> (_q_value=...) at > > /usr/include/qt5/QtCore/qatomic_cxx11.h:239 > > #6 QBasicAtomicInteger<int>::loadRelaxed (this=0x0) at > > /usr/include/qt5/QtCore/qbasicatomic.h:107 > > #7 QtPrivate::RefCount::isShared (this=0x0) at > > /usr/include/qt5/QtCore/qrefcount.h:101 > > #8 QVector<Konsole::Character>::isDetached (this=0x5577df78f208) at > > /usr/include/qt5/QtCore/qvector.h:113 > > Can you tell what was the terminal size when the crash happened? > Specifically, > what was the terminal height? > Were you using a full terminal application (like vi), or in command line? > > -- > You are receiving this mail because: > You are on the CC list for the bug. https://invent.kde.org/utilities/konsole/-/merge_requests/754 - this didn't close when the MR commit |