| Summary: | Incorrect tab index on Login into the KDE Bug Tracking System page | ||
|---|---|---|---|
| Product: | [Applications] drkonqi | Reporter: | Alexander Mentyu <notuxius> |
| Component: | general | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aspotashev, bugseforuns, nate, skierpage |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | 5.13.5 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kwidgetsaddons/1772904c2980ec49a4d3839db9c38a370b88d60a | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Alexander Mentyu
2018-09-05 04:50:29 UTC
Still true in version 5.14.5 on Fedora. The Password field seems to be the first tab index even though it's below the Username field. also confirmed on Arch Linux, plasma 5.15.2. Git commit 1772904c2980ec49a4d3839db9c38a370b88d60a by Harald Sitter. Committed on 24/06/2019 at 10:11. Pushed by sitter into branch 'master'. set the focusPolicy of kpasswordlineedit to the policy of its proxy Summary: this is entirely the same kind of change as done in c695aa5a21a731ab72c8405141b43feccad2b56a a proxy does not automatically adopt the same focus policy as the widget it proxies. instead it has its own policy which is simply the qwidget default. this prevents keyboard focus from working in (e.g.) buddy scenarios as well as when hitting Tab to move through the intractable widgets with a keyboard. seeing as kpasswordlineedit is essentially a lineedit and being able to "tab" from a username edit to a password edit seems a crucial behavioral expectation. CHANGELOG: KPasswordLineEdit now correctly inherits its QLineEdit's focusPolicy Test Plan: designer reports StrongFocus as default now. when using the KPLE without changing its policy it will correctly receive focus through keyboard tabbing Reviewers: cfeck Reviewed By: cfeck Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D21894 M +1 -0 src/kpasswordlineedit.cpp https://commits.kde.org/kwidgetsaddons/1772904c2980ec49a4d3839db9c38a370b88d60a |