Bug 398261

Summary:	Support javascript element on cinemix.radio.net
Product:	[Plasma] plasma-browser-integration	Reporter:	Or Schiro <orschiro>
Component:	Chrome	Assignee:	Kai Uwe Broulik <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugzilla
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-browser-integration/c947306c0c23a0cf3eff4bb151aefc1dacbb1e4b	Version Fixed/Implemented In:
Sentry Crash Report:

Description Or Schiro 2018-09-04 17:26:08 UTC

As per advice from #398203 [1], I am opening this separate bug to track a solution for supporting play/pause for the javascript element on the radio website http://cinemix.radio.net/.

Quoting from #398203:

> The cinemix site uses JavaScript "Audio" instead of HTML5 <audio> tags which we currently don't support. It is not possible to pass JavaScript variables from the website to the extension script. The content script can access the DOM of the website and as such extract <audio> and <video> tags but I haven't found a way yet to pass pure-JS audio/video players around.

[1] https://bugs.kde.org/show_bug.cgi?id=398203

Comment 1 Kai Uwe Broulik 2018-10-26 09:05:00 UTC

*** Bug 400323 has been marked as a duplicate of this bug. ***

Comment 2 Kai Uwe Broulik 2018-10-26 09:10:16 UTC

I came up with a possible solution, can you perhaps try the following patch: https://phabricator.kde.org/D16435

Comment 3 Or Schiro 2018-10-26 09:19:57 UTC

Oh great! Yes, I would like to test it and give you some feedback.  :-)

Can you guide me how I can apply the patch?

Do I need to patch the Chrome extension or the native host?

Comment 4 Kai Uwe Broulik 2018-10-26 09:22:18 UTC

The patch is for the extension, the host part doesn't need any changes for this.

Check out the wiki page on how to load the extension locally [1], you can get the source code from git [2] (I should probably add this to the wiki)

Thanks!

[1] https://community.kde.org/Plasma/Browser_Integration
[2] https://cgit.kde.org/plasma-browser-integration.git

Comment 5 Or Schiro 2018-10-26 11:08:40 UTC

Kai, it's working! I just tested the patch.

Cool, thank you!! :-)

Comment 6 Kai Uwe Broulik 2018-11-26 09:25:40 UTC

Git commit c947306c0c23a0cf3eff4bb151aefc1dacbb1e4b by Kai Uwe Broulik.
Committed on 26/11/2018 at 09:25.
Pushed by broulik into branch 'master'.

Also catch new Audio() elements

Also catches audio players created using the proper new Audio() syntax rather than explicitly creating a DOM element using document.createElement('audio')

Differential Revision: https://phabricator.kde.org/D16435

M  +15   -0    extension/content-script.js

https://commits.kde.org/plasma-browser-integration/c947306c0c23a0cf3eff4bb151aefc1dacbb1e4b

Comment 7 Kai Uwe Broulik 2018-11-29 14:54:09 UTC

*** Bug 395522 has been marked as a duplicate of this bug. ***