Bug 398108

Summary:	Annotation toolbar works only in Browse mode, not in e. g. Text Selection mode.
Product:	[Applications] okular	Reporter:	Thomas Bingel <bingelt>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED FIXED
Severity:	minor	CC:	aacid, nate
Priority:	NOR
Version First Reported In:	1.3.3
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/okular/commit/230a68d537a2f958f72dce162221555ef285896f	Version Fixed In:	21.08
Sentry Crash Report:

Description Thomas Bingel 2018-08-31 19:47:53 UTC

This is more a feature request than a bug report, however I would consider this awkward behavior to be a bug. :-)
First, congratulations, Okular is a nice app!

At the moment, I primarily use Okular to highlight sections in PDF files. However, every so often I see an interesting hyperlink to additional information on the Internet, which I tend to visit, but this requires switching from Browse mode to text selection mode. This is unfortunate, because then the Review bar disappears and I have to press F6 again to restore it, which triggers the text selection mode to switch back to Browse mode. This is very awkward behavior.

Another missing feature in Okular is that you cannot bold face or italicize a text selection. Very unfortunate!

Comment 1 Albert Astals Cid 2018-08-31 20:36:26 UTC

why do you need to switch from browse mode to text mode to click a link?

Comment 2 Laura David Hurka 2019-06-10 17:54:33 UTC

The core of this bug report is that opening the annotation toolbar implies Browse Mode, correct?

Confirmed with Okular 1.7.2...

Comment 3 Thomas Bingel 2019-06-11 02:55:33 UTC

(In reply to Albert Astals Cid from comment #1)
> why do you need to switch from browse mode to text mode to click a link?

I work with research papers a lot. They contain tons of references to other research papers. So if you read an important paragraph in the paper that refers than to another important paper in the references section you would like to immediately check which paper is referred to

Comment 4 Thomas Bingel 2019-06-11 02:57:48 UTC

(In reply to David Hurka from comment #2)
> The core of this bug report is that opening the annotation toolbar implies
> Browse Mode, correct?
> 
> Confirmed with Okular 1.7.2...

Not sure what you mean by "confirmed".

Anyway, as I originally said this is more a feature request than a bug report.
To emphasize, as a heavy user of Okular it is very cumbersome that the use of the annotation bar forces you to change the mode back and forth from annotating back to reading ...

Comment 5 Bug Janitor Service 2021-06-05 17:47:16 UTC

A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/439

Comment 6 Albert Astals Cid 2021-06-19 15:59:35 UTC

Git commit 230a68d537a2f958f72dce162221555ef285896f by Albert Astals Cid, on behalf of Simone Gaiarin.
Committed on 19/06/2021 at 14:12.
Pushed by aacid into branch 'master'.

Uncheck mouse mode action when annotation tool selected

When the annotation is unchecked the previous mouse mode is restored.

The slot slotMouseNormalToggled is changed back to its original version
of slotSetMouseNormal given that we needed to pass the checked state
only to detach the annotations, and we do it in the lambda now.
Related: bug 437377

FIXED-IN: 21.08

M  +11   -5    autotests/annotationtoolbartest.cpp
M  +45   -15   part/pageview.cpp
M  +1    -1    part/pageview.h
M  +2    -2    part/pageviewannotator.cpp
M  +4    -1    part/pageviewannotator.h

https://invent.kde.org/graphics/okular/commit/230a68d537a2f958f72dce162221555ef285896f