Bug 397958

Summary:	Impossible to use knsrc file for uploads from non standard location
Product:	[Frameworks and Libraries] frameworks-knewstuff	Reporter:	Ralf Habacker <ralf.habacker>
Component:	general	Assignee:	Jeremy Whiting <jpwhiting>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kdelibs-bugs-null, sitter
Priority:	NOR
Version First Reported In:	5.49.0
Target Milestone:	---
Platform:	Other
OS:	All
Latest Commit:	https://commits.kde.org/knewstuff/b6a52eef1ab66984795cc4089c78195b7513443f	Version Fixed/Implemented In:	5.51
Sentry Crash Report:
Bug Depends on:
Bug Blocks:	397112

Description Ralf Habacker 2018-08-27 22:40:06 UTC

KNS3::UploadDialog() does not support loading knsrc files from a custom location

How to reproduce:
1. compile knewstuff
2. run <build-dir>/bin/khotnewstuff_upload <knew-stuff-source-dir>/tests/khotnewstuff_upload.knsrc

What happens:
The test case prints "No knsrc file named '<knew-stuff-source-dir>/tests/khotnewstuff_upload.knsrc' was found."

What is expected:
The test case should read the specified file

Additional informations:
KNS3::DownloadDialog() does not have this problem. It could load a knsrc file from any location.

Comment 1 Ralf Habacker 2018-09-13 14:34:02 UTC

For the related review request see https://phabricator.kde.org/D15481

Comment 2 Ralf Habacker 2018-09-13 15:31:34 UTC

Git commit b6a52eef1ab66984795cc4089c78195b7513443f by Ralf Habacker.
Committed on 13/09/2018 at 15:31.
Pushed by habacker into branch 'master'.

Fix 'Impossible to use knsrc file for uploads from non standard location'

Test Plan: build and did run test case on linux
Reviewed By: whiting
Differential Revision: https://phabricator.kde.org/D15481
FIXED-IN:5.51

M  +13   -9    src/uploaddialog.cpp

https://commits.kde.org/knewstuff/b6a52eef1ab66984795cc4089c78195b7513443f

Comment 3 Ralf Habacker 2018-09-13 17:41:05 UTC

*** Bug 386678 has been marked as a duplicate of this bug. ***