Bug 397863

Summary: Discover crashes somewhere in QQuickMenu
Product: [Applications] Discover Reporter: Alexander Mentyu <notuxius>
Component: discoverAssignee: Aleix Pol <aleixpol>
Status: RESOLVED FIXED    
Severity: crash CC: aisaac.olin, bugseforuns, cesar, contact, kde, khromier, marcio.bianco, mustafa1024m, nate, samuraicer, wowhellmail, xilats.dert
Priority: NOR Keywords: drkonqi
Version: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://commits.kde.org/kirigami/91c4be04be103cbf3e748e0d6bd1882fe2fc4b20 Version Fixed In: 5.51
Sentry Crash Report:
Attachments: New crash information added by DrKonqi
New crash information added by DrKonqi
New crash information added by DrKonqi

Description Alexander Mentyu 2018-08-25 12:36:53 UTC 
Application: plasma-discover (5.13.80)

Qt Version: 5.11.1
Frameworks Version: 5.50.0
Operating System: Linux 4.15.0-29-generic x86_64
Distribution: KDE neon Developer Edition

-- Information about the crash:
- What I was doing when the application crashed:

I just entered one or two symbols in top left searchbox and Discover and it crashed immediatelly

-- Backtrace:
Application: Discover (plasma-discover), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f1b148008c0 (LWP 19414))]

Thread 8 (Thread 0x7f1ad37fe700 (LWP 19427)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1  0x00007f1b104c65cb in QWaitConditionPrivate::wait (time=18446744073709551615, this=0x3ac9ba0) at thread/qwaitcondition_unix.cpp:143
#2  QWaitCondition::wait (this=<optimized out>, mutex=0x3ac9690, time=18446744073709551615) at thread/qwaitcondition_unix.cpp:215
#3  0x00007f1b1398a5ad in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#4  0x00007f1b1398aa31 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#5  0x00007f1b104c5727 in QThreadPrivate::start (arg=0x3ac9610) at thread/qthread_unix.cpp:367
#6  0x00007f1b0c5636ba in start_thread (arg=0x7f1ad37fe700) at pthread_create.c:333
#7  0x00007f1b0fac941d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 7 (Thread 0x7f1ad3fff700 (LWP 19426)):
#0  0x00007f1b0fabd74d in poll () at ../sysdeps/unix/syscall-template.S:84
#1  0x00007f1b0a6fe38c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007f1b0a6fe49c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007f1b106de0bb in QEventDispatcherGlib::processEvents (this=0x7f1acc0008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#4  0x00007f1b106855ba in QEventLoop::exec (this=this@entry=0x7f1ad3ffecf0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:214
#5  0x00007f1b104ba5e4 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:525
#6  0x00007f1b104c5727 in QThreadPrivate::start (arg=0x11904b0) at thread/qthread_unix.cpp:367
#7  0x00007f1b0c5636ba in start_thread (arg=0x7f1ad3fff700) at pthread_create.c:333
#8  0x00007f1b0fac941d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 6 (Thread 0x7f1ae331a700 (LWP 19419)):
#0  0x00007f1b0a742a92 in g_mutex_unlock () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x00007f1b0a6fd910 in g_main_context_prepare () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007f1b0a6fe2bb in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007f1b0a6fe49c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x00007f1b106de0bb in QEventDispatcherGlib::processEvents (this=0x7f1ad40008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#5  0x00007f1b106855ba in QEventLoop::exec (this=this@entry=0x7f1ae3319cf0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:214
#6  0x00007f1b104ba5e4 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:525
#7  0x00007f1b104c5727 in QThreadPrivate::start (arg=0x150ccc0) at thread/qthread_unix.cpp:367
#8  0x00007f1b0c5636ba in start_thread (arg=0x7f1ae331a700) at pthread_create.c:333
#9  0x00007f1b0fac941d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 5 (Thread 0x7f1ae4853700 (LWP 19418)):
#0  0x00007f1b0fabd74d in poll () at ../sysdeps/unix/syscall-template.S:84
#1  0x00007f1b0a6fe38c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007f1b0a6fe49c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007f1b106de0bb in QEventDispatcherGlib::processEvents (this=0x7f1adc0008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#4  0x00007f1b106855ba in QEventLoop::exec (this=this@entry=0x7f1ae4852cf0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:214
#5  0x00007f1b104ba5e4 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:525
#6  0x00007f1b104c5727 in QThreadPrivate::start (arg=0x14bfb90) at thread/qthread_unix.cpp:367
#7  0x00007f1b0c5636ba in start_thread (arg=0x7f1ae4853700) at pthread_create.c:333
#8  0x00007f1b0fac941d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 4 (Thread 0x7f1aed374700 (LWP 19417)):
#0  0x00007f1b0fabd74d in poll () at ../sysdeps/unix/syscall-template.S:84
#1  0x00007f1b0a6fe38c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007f1b0a6fe49c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007f1b106de0bb in QEventDispatcherGlib::processEvents (this=0x7f1ae80008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#4  0x00007f1b106855ba in QEventLoop::exec (this=this@entry=0x7f1aed373c80, flags=..., flags@entry=...) at kernel/qeventloop.cpp:214
#5  0x00007f1b104ba5e4 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:525
#6  0x00007f1b13909f86 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#7  0x00007f1b104c5727 in QThreadPrivate::start (arg=0x1432710) at thread/qthread_unix.cpp:367
#8  0x00007f1b0c5636ba in start_thread (arg=0x7f1aed374700) at pthread_create.c:333
#9  0x00007f1b0fac941d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 3 (Thread 0x7f1afdc9a700 (LWP 19416)):
#0  0x00007f1b0fab927d in read () at ../sysdeps/unix/syscall-template.S:84
#1  0x00007f1b0a7416f0 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007f1b0a6fde74 in g_main_context_check () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007f1b0a6fe330 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x00007f1b0a6fe49c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5  0x00007f1b106de0bb in QEventDispatcherGlib::processEvents (this=0x7f1af00008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#6  0x00007f1b106855ba in QEventLoop::exec (this=this@entry=0x7f1afdc99cd0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:214
#7  0x00007f1b104ba5e4 in QThread::exec (this=this@entry=0xce2f90) at thread/qthread.cpp:525
#8  0x00007f1b11045195 in QQmlThreadPrivate::run (this=0xce2f90) at qml/ftw/qqmlthread.cpp:148
#9  0x00007f1b104c5727 in QThreadPrivate::start (arg=0xce2f90) at thread/qthread_unix.cpp:367
#10 0x00007f1b0c5636ba in start_thread (arg=0x7f1afdc9a700) at pthread_create.c:333
#11 0x00007f1b0fac941d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 2 (Thread 0x7f1afeeab700 (LWP 19415)):
#0  0x00007f1b0fabd74d in poll () at ../sysdeps/unix/syscall-template.S:84
#1  0x00007f1b0a6fe38c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007f1b0a6fe49c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007f1b106de0bb in QEventDispatcherGlib::processEvents (this=0x7f1af80008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#4  0x00007f1b106855ba in QEventLoop::exec (this=this@entry=0x7f1afeeaacc0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:214
#5  0x00007f1b104ba5e4 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:525
#6  0x00007f1b12400f35 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5
#7  0x00007f1b104c5727 in QThreadPrivate::start (arg=0x7f1b12679d60) at thread/qthread_unix.cpp:367
#8  0x00007f1b0c5636ba in start_thread (arg=0x7f1afeeab700) at pthread_create.c:333
#9  0x00007f1b0fac941d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 1 (Thread 0x7f1b148008c0 (LWP 19414)):
[KCrash Handler]
#6  0x00007f1b0229661c in QQuickMenuPrivate::setParentMenu(QQuickMenu*) () from /usr/lib/x86_64-linux-gnu/libQt5QuickTemplates2.so.5
#7  0x00007f1b02297d2b in QQuickMenuPrivate::removeItem(int, QQuickItem*) () from /usr/lib/x86_64-linux-gnu/libQt5QuickTemplates2.so.5
#8  0x00007f1b139c1a13 in QQuickItemPrivate::itemChange(QQuickItem::ItemChange, QQuickItem::ItemChangeData const&) () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#9  0x00007f1b139ceb17 in QQuickItem::setParentItem(QQuickItem*) () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#10 0x00007f1b139cf71c in QQuickItem::~QQuickItem() () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#11 0x00007f1b139cfa99 in QQuickItem::~QQuickItem() () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#12 0x00007f1b106b1af3 in QObjectPrivate::deleteChildren (this=this@entry=0x21d65d0) at kernel/qobject.cpp:1997
#13 0x00007f1b106bbbe4 in QObject::~QObject (this=<optimized out>, __in_chrg=<optimized out>) at kernel/qobject.cpp:1025
#14 0x00007f1b139cf82c in QQuickItem::~QQuickItem() () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#15 0x00007f1b139ee476 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#16 0x00007f1b106b1af3 in QObjectPrivate::deleteChildren (this=this@entry=0x221d410) at kernel/qobject.cpp:1997
#17 0x00007f1b106bbbe4 in QObject::~QObject (this=<optimized out>, __in_chrg=<optimized out>) at kernel/qobject.cpp:1025
#18 0x00007f1af403a6ae in ?? () from /usr/lib/x86_64-linux-gnu/qt5/qml/QtQuick/Templates.2/libqtquicktemplates2plugin.so
#19 0x00007f1b106b1af3 in QObjectPrivate::deleteChildren (this=this@entry=0x1bfca80) at kernel/qobject.cpp:1997
#20 0x00007f1b106bbbe4 in QObject::~QObject (this=<optimized out>, __in_chrg=<optimized out>) at kernel/qobject.cpp:1025
#21 0x00007f1b139cf82c in QQuickItem::~QQuickItem() () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#22 0x00007f1b139ee626 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#23 0x00007f1b106b1af3 in QObjectPrivate::deleteChildren (this=this@entry=0x2005180) at kernel/qobject.cpp:1997
#24 0x00007f1b106bbbe4 in QObject::~QObject (this=<optimized out>, __in_chrg=<optimized out>) at kernel/qobject.cpp:1025
#25 0x00007f1b139cf82c in QQuickItem::~QQuickItem() () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#26 0x00007f1b139ee0a6 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#27 0x00007f1b106b4ff0 in QObject::event (this=0x24c37d0, e=<optimized out>) at kernel/qobject.cpp:1242
#28 0x00007f1b139cd9ab in QQuickItem::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Quick.so.5
#29 0x00007f1b11ce139c in QApplicationPrivate::notify_helper (this=<optimized out>, receiver=0x24c37d0, e=0x1d011b0) at kernel/qapplication.cpp:3727
#30 0x00007f1b11ce8ab0 in QApplication::notify (this=0x7ffdfea1bf30, receiver=0x24c37d0, e=0x1d011b0) at kernel/qapplication.cpp:3486
#31 0x00007f1b10687228 in QCoreApplication::notifyInternal2 (receiver=0x24c37d0, event=event@entry=0x1d011b0) at kernel/qcoreapplication.cpp:1048
#32 0x00007f1b10689e2e in QCoreApplication::sendEvent (event=0x1d011b0, receiver=<optimized out>) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:234
#33 QCoreApplicationPrivate::sendPostedEvents (receiver=receiver@entry=0x0, event_type=event_type@entry=0, data=0xc749f0) at kernel/qcoreapplication.cpp:1745
#34 0x00007f1b1068a2a8 in QCoreApplication::sendPostedEvents (receiver=receiver@entry=0x0, event_type=event_type@entry=0) at kernel/qcoreapplication.cpp:1599
#35 0x00007f1b106dea93 in postEventSourceDispatch (s=0xcc4500) at kernel/qeventdispatcher_glib.cpp:276
#36 0x00007f1b0a6fe197 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#37 0x00007f1b0a6fe3f0 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#38 0x00007f1b0a6fe49c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#39 0x00007f1b106de09f in QEventDispatcherGlib::processEvents (this=0xd00070, flags=...) at kernel/qeventdispatcher_glib.cpp:423
#40 0x00007f1b044ef421 in QPAEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/x86_64-linux-gnu/libQt5WaylandClient.so.5
#41 0x00007f1b106855ba in QEventLoop::exec (this=this@entry=0x7ffdfea1be50, flags=..., flags@entry=...) at kernel/qeventloop.cpp:214
#42 0x00007f1b1068e6c4 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:1336
#43 0x00007f1b114ccf8c in QGuiApplication::exec () at kernel/qguiapplication.cpp:1762
#44 0x00007f1b11ce12f5 in QApplication::exec () at kernel/qapplication.cpp:2901
#45 0x00000000004133ff in main (argc=1, argv=<optimized out>) at /workspace/build/discover/main.cpp:156

Reported using DrKonqi
Comment 1 Aleix Pol 2018-08-31 15:50:01 UTC 
*** Bug 398003 has been marked as a duplicate of this bug. ***
Comment 2 Aleix Pol 2018-08-31 15:51:24 UTC 
*** Bug 397907 has been marked as a duplicate of this bug. ***
Comment 3 Aleix Pol 2018-08-31 15:51:47 UTC 
*** Bug 397955 has been marked as a duplicate of this bug. ***
Comment 4 Aleix Pol 2018-08-31 15:52:06 UTC 
*** Bug 397997 has been marked as a duplicate of this bug. ***
Comment 5 Sefa Eyeoglu 2018-09-15 14:31:57 UTC 
Created attachment 114975 [details]
New crash information added by DrKonqi

plasma-discover (5.13.90) using Qt 5.11.1

- What I was doing when the application crashed:
Open Applications tab in sidebar.

Using KDE-Unstable repo in Archlinux

-- Backtrace (Reduced):
#6  0x00007f9ad50f5aa8 in QQuickMenuPrivate::setParentMenu(QQuickMenu*) () at /usr/lib/libQt5QuickTemplates2.so.5
#7  0x00007f9ad50f7302 in QQuickMenuPrivate::removeItem(int, QQuickItem*) () at /usr/lib/libQt5QuickTemplates2.so.5
#8  0x00007f9ae0b622b7 in QQuickItemPrivate::itemChange(QQuickItem::ItemChange, QQuickItem::ItemChangeData const&) () at /usr/lib/libQt5Quick.so.5
#9  0x00007f9ae0b68046 in QQuickItem::setParentItem(QQuickItem*) () at /usr/lib/libQt5Quick.so.5
#10 0x00007f9ae0b6943d in QQuickItem::~QQuickItem() () at /usr/lib/libQt5Quick.so.5
Comment 6 Nate Graham 2018-09-24 15:05:56 UTC 
*** Bug 399005 has been marked as a duplicate of this bug. ***
Comment 7 Aleix Pol 2018-09-24 17:47:31 UTC 
Git commit 91c4be04be103cbf3e748e0d6bd1882fe2fc4b20 by Aleix Pol.
Committed on 24/09/2018 at 17:43.
Pushed by apol into branch 'master'.

Don't actively destroy menu items

They will be destroyed by their parent, as they get reparented as soon
as addMenu/addItem is called.
For some reason this triggers a crash in some strange situations (e.g.
when construction/destruction happens quickly).

M  +0    -2    src/controls/private/ActionsMenu.qml

https://commits.kde.org/kirigami/91c4be04be103cbf3e748e0d6bd1882fe2fc4b20
Comment 8 Nate Graham 2018-10-10 17:18:38 UTC 
*** Bug 399576 has been marked as a duplicate of this bug. ***
Comment 9 Nate Graham 2018-10-10 17:19:37 UTC 
*** Bug 399555 has been marked as a duplicate of this bug. ***
Comment 10 Nate Graham 2018-10-10 17:19:43 UTC 
*** Bug 399556 has been marked as a duplicate of this bug. ***
Comment 11 Nate Graham 2018-10-10 17:19:53 UTC 
*** Bug 399559 has been marked as a duplicate of this bug. ***
Comment 12 Nate Graham 2018-10-10 17:21:02 UTC 
Re-opening; we've got a bunch of new crashes from 5.14.
Comment 13 Christoph Feck 2018-10-10 21:20:58 UTC 
Commit from comment #7 is in kirigami 5.51, which is not released yet.
Comment 14 Nate Graham 2018-10-10 21:22:23 UTC 
Oh lol of course. Let's re-open again if the crashes keep crashing after 5.51 is in users' hands.
Comment 15 Xilats 2018-10-11 19:58:13 UTC 
Created attachment 115578 [details]
New crash information added by DrKonqi

plasma-discover (5.14.0) using Qt 5.11.2

- What I was doing when the application crashed:
I was trying to uninstall a package.
- Unusual behavior I noticed:
Severe lag, .knsrc errors in terminal output, applications simply do not uninstall, they just are stuck in the task queue.

-- Backtrace (Reduced):
#6  0x00007f2e9b72a1d8 in QQuickMenuPrivate::setParentMenu(QQuickMenu*) () at /usr/lib/libQt5QuickTemplates2.so.5
#7  0x00007f2e9b72ba32 in QQuickMenuPrivate::removeItem(int, QQuickItem*) () at /usr/lib/libQt5QuickTemplates2.so.5
#8  0x00007f2ea5099347 in QQuickItemPrivate::itemChange(QQuickItem::ItemChange, QQuickItem::ItemChangeData const&) () at /usr/lib/libQt5Quick.so.5
#9  0x00007f2ea509f0d6 in QQuickItem::setParentItem(QQuickItem*) () at /usr/lib/libQt5Quick.so.5
#10 0x00007f2ea50a04cd in QQuickItem::~QQuickItem() () at /usr/lib/libQt5Quick.so.5
Comment 16 Charles Riley 2018-10-14 17:23:36 UTC 
Created attachment 115643 [details]
New crash information added by DrKonqi

plasma-discover (5.14.0) using Qt 5.11.1

- What I was doing when the application crashed:

Just searching for an application within Discover and the application crashed.

-- Backtrace (Reduced):
#6  QMetaObjectPrivate::disconnect (sender=0x321, signal_index=53, smeta=0x7f91b11de340 <QQuickMenu::staticMetaObject>, receiver=0x5e1, method_index=-1, slot=0x7ffcce0b6cd0, disconnectType=QMetaObjectPrivate::DisconnectAll) at kernel/qobject.cpp:3424
#7  0x00007f91c17a67a7 in QObject::disconnectImpl (sender=0x321, signal=signal@entry=0x7ffcce0b6cc0, receiver=receiver@entry=0x5e1, slot=slot@entry=0x7ffcce0b6cd0, senderMetaObject=senderMetaObject@entry=0x7f91b11de340 <QQuickMenu::staticMetaObject>) at kernel/qobject.cpp:4986
#8  0x00007f91b0f4f0b1 in QObject::disconnect<void (QQuickMenu::*)(bool), void (QQuickMenu::*)(bool)> (slot=(void (QQuickMenu::*)(QQuickMenu * const, bool)) 0x7f91b0f4e820 <QQuickMenu::setCascade(bool)>, receiver=0x5e1, signal=(void (QQuickMenu::*)(QQuickMenu * const, bool)) 0x7f91b0f4dc10 <QQuickMenu::cascadeChanged(bool)>, sender=<optimized out>) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:367
#9  QQuickMenuPrivate::setParentMenu (this=0x5599c808e670, parent=parent@entry=0x0) at qquickmenu.cpp:486
#10 0x00007f91b0f505cb in QQuickMenuPrivate::removeItem (this=0x5599c6412bb0, index=<optimized out>, item=<optimized out>) at qquickmenu.cpp:238
Comment 17 Aleix Pol 2018-10-15 13:12:23 UTC 
*** Bug 399559 has been marked as a duplicate of this bug. ***