| Summary: | Safe assert when copy/pasting a transform mask | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Halla Rempt <halla> |
| Component: | Layer Stack | Assignee: | Halla Rempt <halla> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | dimula73, freebox64 |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kde/krita/commit/1b932bd47ad00202e9d22c37396582c34bd2b4de | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Halla Rempt
2018-08-23 15:14:36 UTC
Confirming :) (Version: 4.2.0-pre-alpha (git 04931e4) - Ubuntu 14.04) Git commit efb062b8de124cbe32c9f0f219d16a4009b15268 by Boudewijn Rempt. Committed on 09/05/2019 at 11:10. Pushed by rempt into branch 'master'. Allow masks on group layers When copying a mask to the clipboard, the masks are added to a default, empty image. That means, to a group layer without a parent. This is perfectly fine, but we have never allowed it before. The only important check is whether the root layer already has a selection mask, the global selection. M +11 -4 libs/image/kis_group_layer.cc https://invent.kde.org/kde/krita/commit/efb062b8de124cbe32c9f0f219d16a4009b15268 The fix is reverted by Boud Git commit ad3649935d0a2a7c9b6e4f6fecc421c69e53c3ca by Dmitry Kazakov. Committed on 16/05/2019 at 21:00. Pushed by dkazakov into branch 'master'. Recover forbidding rule for adding masks to the root layer We shoould not allow adding a mask to normal root layers. It makes painters confused. But for clipboard contents is it perfectly okay, so just add an option for it. M +8 -0 libs/image/kis_group_layer.cc M +12 -0 libs/image/kis_image.cc M +12 -0 libs/image/kis_image.h M +1 -0 libs/ui/kis_mimedata.cpp https://invent.kde.org/kde/krita/commit/ad3649935d0a2a7c9b6e4f6fecc421c69e53c3ca Git commit e2bdef9254b300f5698cf8696d77434154cfde30 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 17/05/2019 at 08:12. Pushed by rempt into branch 'krita/4.2'. Recover forbidding rule for adding masks to the root layer We shoould not allow adding a mask to normal root layers. It makes painters confused. But for clipboard contents is it perfectly okay, so just add an option for it. M +8 -0 libs/image/kis_group_layer.cc M +12 -0 libs/image/kis_image.cc M +12 -0 libs/image/kis_image.h M +1 -0 libs/ui/kis_mimedata.cpp https://invent.kde.org/kde/krita/commit/e2bdef9254b300f5698cf8696d77434154cfde30 Git commit ad31625eae8f9701e5de65b11d79065139ce3741 by Dmitry Kazakov. Committed on 20/05/2019 at 12:33. Pushed by dkazakov into branch 'master'. One more try to fix restriction for adding masks to the root layer We should not allow adding a mask to normal root layers. It makes painters confused. But for clipboard contents is it perfectly okay, so just add an option for it. It the previous version the check for the presence of a global selection mask was incorrect. Related: bug 407375, bug 407665 BACKPORT:krita/4.2 M +15 -3 libs/image/kis_group_layer.cc M +12 -0 libs/image/kis_image.cc M +12 -0 libs/image/kis_image.h M +1 -0 libs/ui/kis_mimedata.cpp M +5 -2 libs/ui/tool/kis_selection_tool_helper.cpp https://invent.kde.org/kde/krita/commit/ad31625eae8f9701e5de65b11d79065139ce3741 Git commit 1b932bd47ad00202e9d22c37396582c34bd2b4de by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 21/05/2019 at 07:23. Pushed by rempt into branch 'krita/4.2'. One more try to fix restriction for adding masks to the root layer We should not allow adding a mask to normal root layers. It makes painters confused. But for clipboard contents is it perfectly okay, so just add an option for it. It the previous version the check for the presence of a global selection mask was incorrect. Related: bug 407375, bug 407665 BACKPORT:krita/4.2 M +15 -3 libs/image/kis_group_layer.cc M +12 -0 libs/image/kis_image.cc M +12 -0 libs/image/kis_image.h M +1 -0 libs/ui/kis_mimedata.cpp M +5 -2 libs/ui/tool/kis_selection_tool_helper.cpp https://invent.kde.org/kde/krita/commit/1b932bd47ad00202e9d22c37396582c34bd2b4de |