Summary: | Cards don't autoplay to the foundations / deck in FreeCell | ||
---|---|---|---|
Product: | [Applications] kpat | Reporter: | Pentti Nuutinen <penuutinen> |
Component: | solver | Assignee: | Stephan Kulow <coolo> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | 0inkane, aacid, kde-games-bugs, shlomif |
Priority: | NOR | ||
Version: | 3.6 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kpat/fac28f110c0a9c976677bee2d9d2126f93a711fd | Version Fixed In: | |
Attachments: |
Patch to fix the problem
Newer patch with some cleanups. |
Description
Pentti Nuutinen
2018-08-23 04:39:06 UTC
This problem appears to have been introduced in commit ed0e53e0888da7123f4a0d2097f8da7fb105ca18 ( see https://phabricator.kde.org/D12415 ). I'll try to investigate. Created attachment 114575 [details]
Patch to fix the problem
Tested and seems to be fine
Setting status to confirmed. Created attachment 114586 [details]
Newer patch with some cleanups.
Shlomi please use arc/phabricator for patches next time, it's better for reviews I'll commit this. Git commit fac28f110c0a9c976677bee2d9d2126f93a711fd by Albert Astals Cid, on behalf of Shlomi Fish. Committed on 28/08/2018 at 21:39. Pushed by aacid into branch 'Applications/18.08'. FreeCell: Restore cards autoplaying to foundation M +7 -5 patsolve/abstract_fc_solve_solver.cpp M +2 -2 patsolve/abstract_fc_solve_solver.h M +162 -118 patsolve/freecellsolver.cpp M +3 -3 patsolve/freecellsolver.h M +5 -0 patsolve/simonsolver.cpp M +1 -1 patsolve/simonsolver.h M +3 -0 patsolve/solverinterface.h https://commits.kde.org/kpat/fac28f110c0a9c976677bee2d9d2126f93a711fd |