Summary: | No global menu from flatpak KDE applications | ||
---|---|---|---|
Product: | [Frameworks and Libraries] flatpak-platform-plugin | Reporter: | avlas <jsardid> |
Component: | general | Assignee: | Jan Grulich <jgrulich> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aleixpol, jgrulich, nate |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
URL: | https://github.com/flatpak/flatpak/issues/2012 | ||
Latest Commit: | https://cgit.kde.org/flatpak-kde-applications.git/commit/?id=0ccbc716568441922961a8ae372284a9d07be882 | Version Fixed In: | |
Sentry Crash Report: |
Description
avlas
2018-08-19 14:35:32 UTC
Which apps? All apps? Some apps? Do any of them work? I tried okular, kdenlive and octave (even though octave is not a kde application, it relies on kde and worked fine before). So, I'm not 100% sure about all applications that I didn't test, but it seems like globalmenu does not work anymore for flatpak kde(-dependent) apps... Thanks for the information! Mmm, it may be a bug in flatpak as globalmenu works for flatpak 0.11.7 but not for flatpak 1.0.0. Reported in https://github.com/flatpak/flatpak/issues/2012 Thanks, let's see what shakes out there. If need be, we can re-open this. Sounds good (In reply to Nate Graham from comment #5) > Thanks, let's see what shakes out there. If need be, we can re-open this. Reopening this issue. Please see: flatpak/flatpak#2012 In short, Flatpak stopped inheriting permission requests from the runtime. The apps need to list the permissions themselves. Perhaps adding "--talk-name=com.canonical.AppMenu.Registrar", to "finish-args" and rebuilding will be enough (not sure about '--filesytem'... ) > Please see: flatpak/flatpak#2012 I meant https://github.com/flatpak/flatpak/issues/2012 Thanks. I'll see if I can engage with upstream on the matter too. (In reply to Nate Graham from comment #9) > Thanks. I'll see if I can engage with upstream on the matter too. Great, thank you! (In reply to Nate Graham from comment #9) > Thanks. I'll see if I can engage with upstream on the matter too. Any update? Sadly not. Git commit 92e9bd4843aba0e005a2dfb7b57090d75b4bf1ce by Aleix Pol. Committed on 03/10/2018 at 21:57. Pushed by apol into branch 'master'. Add missing appmenu dbus path M +1 -0 org.kde.Sdk.json https://commits.kde.org/flatpak-kde-runtime/92e9bd4843aba0e005a2dfb7b57090d75b4bf1ce Aleix, this is currently an upstream issue (https://github.com/flatpak/flatpak/issues/2012). In words of Alex Larsson, "We stopped inheriting permission requests from the runtime. The apps need to list the permissions themselves", so your commit, being part of the runtime, is not able to fix the issue. I guess the two options right now are either to (try to) convince upstream developers to revert that policy upstream whenever possible, or to start adding all these arguments to the applications instead of to the runtimes... Another thing that gets affected, in addition to the global menu, is the look and feel, so applications load the breeze color theme, even though the native system uses a different color theme. Then there's nothing we can do on our end. (In reply to Aleix Pol from comment #15) > Then there's nothing we can do on our end. Well, if this finally doesn't get reverted upstream, then all KDE flatpak applications need to do this, so I guess this is still an open KDE issue anyways. I tried to get an explicit answer to the question if this is going to be reverted or not upstream but so far the question is being ignored... If somebody is interested exporting the menu can be fixed on the fly with: sudo flatpak override --talk-name=com.canonical.AppMenu.Registrar flatpak_application_name sudo flatpak override --talk-name=com.canonical.AppMenu.Registrar.* flatpak_aplication_name And for the look and feel: sudo flatpak override --filesystem=xdg-config/kdeglobals:ro flatpak_aplication_name I updated all KDE apps, see https://phabricator.kde.org/D15958. I'll also go through flathub and try to update all applications there as well. (In reply to Jan Grulich from comment #18) > I updated all KDE apps, see https://phabricator.kde.org/D15958. I'll also go > through flathub and try to update all applications there as well. Jan, do you know the way to make flatpak apps to follow the default system applications from KDE settings? Thanks in advance (In reply to avlas from comment #19) > Jan, do you know the way to make flatpak apps to follow the default system > applications from KDE settings? Thanks in advance Actually I saw it sort of follows it, but not quite properly, at least for the browser application. My setting is to use the browser based on URL type, but this is not followed. Please let me know if it's better if I fill another bug for this... This has been properly solved in flatpak upstream. (In reply to Aleix Pol from comment #21) > This has been properly solved in flatpak upstream. Nice Inheritance of permissions is back in flatpak 1.0.4: https://github.com/flatpak/flatpak/releases Changes in 1.0.4 - Flatpak 0.99.1 removed the inheritance of permissions from the runtime due to concerns with dynamic app permissions. Due to popular requests, this version re-introduces such inheritance, but does it instead at build time. This solved the issues with dynamic permissions while still allowing runtimes to have default permissions. Apps can disable this by passing --no-inherit-permissions to build-finish. Are there plans to revert this commit (https://phabricator.kde.org/D15958) adding those changes back to the kde flatpak runtime? Mmm, actually these changes (kdeglobals and registrar) were never removed from the kde runtime, were they? No, they're still in, we do need the applications to rebuild with latest flatpak-builder though. (In reply to Aleix Pol from comment #26) > No, they're still in, we do need the applications to rebuild with latest > flatpak-builder though. Thank you |