Summary: | seeking a player past 33m22s resets seek bar to 00:00 | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Alexander Terry <alexterry43> |
Component: | Media Player | Assignee: | arsenarsentmc |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | arsenarsentmc, emailmeat, kde, plasma-bugs |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-workspace/1bb02b98cfedfd6b51ac8de0c34a5778659433f7 | Version Fixed In: | 5.12.7 |
Attachments: | Changing the position to a double the same way the length was changed to a double fixes the media player |
Description
Alexander Terry
2018-08-18 16:06:09 UTC
*** This bug has been marked as a duplicate of bug 377623 *** While this is technically a duplicate issue, the resolution of #377623 did not cover the position, which is what this issue is about. I'd like to provide new reproduction steps though: 1) Open a file in a media player and seek it to 34 minutes 2) Try to seek the file using the Plasma media player 3) The media player seek bar resets to 00:00 I've also found that pushing past the point of 36 minutes seems to reset the Plasma media player back to 00:00 Created attachment 114791 [details]
Changing the position to a double the same way the length was changed to a double fixes the media player
Thanks for the investigation. Is the patch from comment #3 the correct diff, or the reverse diff going from the fixed version to the current version? It is in reverse, my bad. I wrote it in a hurry and ended up swapping the operands. Thanks for your patch! Indeed changing the property to double should fix this since we had a similar overflow issue with the "Length" property that was also changed to a double. Can you please upload that patch to Phabricator [1] for review, as patches on the bug tracker often get overlooked? You'll find more information on our wiki [2]. Thanks! [1] https://phabricator.kde.org/ [2] https://community.kde.org/Get_Involved/development Git commit 1bb02b98cfedfd6b51ac8de0c34a5778659433f7 by Kai Uwe Broulik, on behalf of Arsen Arsen. Committed on 06/09/2018 at 08:29. Pushed by broulik into branch 'Plasma/5.12'. [Media Player] Change int to double for positions In previous versions of Plasma, media player had an overflow bug in positions, leading to the player resetting to 00:00. This only affects files longer than around 33 minutes 20 seconds. FIXED-IN: 5.12.7 Differential Revision: https://phabricator.kde.org/D15311 M +1 -1 applets/mediacontroller/contents/ui/ExpandedRepresentation.qml https://commits.kde.org/plasma-workspace/1bb02b98cfedfd6b51ac8de0c34a5778659433f7 *** Bug 368707 has been marked as a duplicate of this bug. *** |