| Summary: | Commit c8c3e98d21a91935631a3a189aacd9ff9200c965 breaks build with Julia 0.6.4 | ||
|---|---|---|---|
| Product: | [Applications] cantor | Reporter: | Antonio Rojas <arojas> |
| Component: | julia-backend | Assignee: | Nikita Sirgienko <warquark> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexander.semke, filipe |
| Priority: | NOR | ||
| Version First Reported In: | 18.08 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/cantor/e03e3d91ee8739021998f5cd817ba49924400ce3 | Version Fixed In: | |
| Sentry Crash Report: | |||
I have a fix for this. Should i just push it, or i need something else before it? Could you attach the patch here in the meantime so I can apply it to our packages? I can append the patch only after a hour. But if is too long for you, you can use 90b001d commit from master. Ah, if it's fixed in master I can get the patch from there, thanks Should I cherry pick the fix commit, for future builds? Git commit e03e3d91ee8739021998f5cd817ba49924400ce3 by Nikita Sirgienko. Committed on 19/08/2018 at 18:23. Pushed by sirgienko into branch 'Applications/18.08'. Fix build error with julia with version greater, that 5 (cherry picked from commit 90b001d1b01556cc5d5b60791e9b43e6dfcff0b4) M +1 -5 src/backends/julia/juliaserver/juliaserver.cpp https://commits.kde.org/cantor/e03e3d91ee8739021998f5cd817ba49924400ce3 |
/build/cantor/src/cantor-18.07.90/src/backends/julia/juliaserver/juliaserver.cpp: In member function ‘QString JuliaServer::fromJuliaString(const jl_value_t*)’: /build/cantor/src/cantor-18.07.90/src/backends/julia/juliaserver/juliaserver.cpp:213:48: error: invalid conversion from ‘const jl_value_t*’ {aka ‘const _jl_value_t*’} to ‘jl_value_t*’ {aka ‘_jl_value_t*’} [-fpermissive] return QString::fromUtf8(jl_string_ptr(value)); ^~~~~